Skip to content

Increase Code Coverage to 90% #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 4 tasks
avivkeller opened this issue Jun 4, 2025 · 4 comments
Open
2 of 4 tasks

Increase Code Coverage to 90% #305

avivkeller opened this issue Jun 4, 2025 · 4 comments

Comments

@avivkeller
Copy link
Member

avivkeller commented Jun 4, 2025

Ref: #304

Our code coverage is currently less than 45% 😬. That is not optimal, since this library has a lot of moving pieces, and many of which are untested.

I propose we:

  • Enable code coverage checks (@nodejs/tsc needs to add Codecov's GitHub bot to this repository)
  • Set patch coverage threshold to 80%
  • Increase coverage to X%, set project coverage threshold to X% for every 10% until 90%.
  • Disable patch coverage threshold, rely on the project threshold
@anonrig
Copy link
Member

anonrig commented Jun 4, 2025

@avivkeller It seems codecov is already enabled for this repository: https://app.codecov.io/gh/nodejs/api-docs-tooling

@avivkeller
Copy link
Member Author

avivkeller commented Jun 4, 2025

@avivkeller It seems codecov is already enabled for this repository: https://app.codecov.io/gh/nodejs/api-docs-tooling

Codecov is enabled, but the bot and status checks have not been added. https://github.com/apps/codecov

Sorry if that wasn't clear

@AugustinMauroy
Copy link
Member

We could already exclude legacy test coverage because we don't care about it 😝

@anonrig
Copy link
Member

anonrig commented Jun 4, 2025

@nodejs/tsc I've enabled codecov github app for this repository.

This was referenced Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants