Skip to content

coverage: increase to ~47% #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

coverage: increase to ~47% #309

merged 4 commits into from
Jun 5, 2025

Conversation

avivkeller
Copy link
Member

Ref: #305 #306 #307

@Copilot Copilot AI review requested due to automatic review settings June 4, 2025 21:46
@avivkeller avivkeller requested a review from a team as a code owner June 4, 2025 21:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases test coverage by adding new test files and exposing previously unexported utility functions. Key changes include converting helper functions to exported functions in legacy JSON utilities and introducing new test cases for parseSignature, parseList, buildHierarchy, and addon-verify utilities.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/generators/legacy-json/utils/parseSignature.mjs Made helper functions exportable to be used externally.
src/generators/legacy-json/utils/parseList.mjs Converted internal functions to exported functions.
src/generators/legacy-json/utils/buildHierarchy.mjs Exported the findParent function for external use.
src/generators/legacy-json/utils/tests/parseSignature.test.mjs Added tests for parseSignature, including method parameter parsing.
src/generators/legacy-json/utils/tests/parseList.test.mjs Added tests for parseList functionality.
src/generators/legacy-json/utils/tests/buildHierarchy.test.mjs Introduced tests for buildHierarchy and its edge cases.
src/generators/addon-verify/utils/tests/section.test.mjs Added tests for section utilities (buildability, normalization, folder name generation).
src/generators/addon-verify/utils/tests/generateFileList.test.mjs Created tests ensuring proper transformation of file contents and binding file generation.

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.34%. Comparing base (aff9339) to head (7261220).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
+ Coverage   39.78%   48.34%   +8.55%     
==========================================
  Files          83       83              
  Lines        6905     6905              
  Branches      208      277      +69     
==========================================
+ Hits         2747     3338     +591     
+ Misses       4155     3564     -591     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller changed the title coverage: increase to ~48% coverage: increase to ~47% Jun 4, 2025
@avivkeller avivkeller merged commit 5eb0658 into main Jun 5, 2025
10 checks passed
@avivkeller avivkeller deleted the coverage/in-48 branch June 5, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants