-
Notifications
You must be signed in to change notification settings - Fork 9
feat(codecov): setup checks #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a Codecov configuration to enforce coverage thresholds on pull requests and the overall project.
- Introduces
codecov.yml
with patch and project coverage status targets - Includes TODOs for raising thresholds once coverage improves
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 41.24% 48.90% +7.66%
==========================================
Files 94 82 -12
Lines 7092 6825 -267
Branches 211 277 +66
==========================================
+ Hits 2925 3338 +413
+ Misses 4164 3484 -680
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This shouldn't land until #307, plus the followup which will get us from 40-ish to 43-ish (so we have a bit of margin) |
bump @avivkeller Linting is failing 😃 |
@nodejs/web-infra Please set
codecov/patch
,codecov/project
,CI / Tests & Coverage
andCI / Lint & Format
as required checks.Ref: #305