Skip to content

feat(codecov): setup checks #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

feat(codecov): setup checks #306

merged 4 commits into from
Jun 5, 2025

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Jun 4, 2025

@nodejs/web-infra Please set codecov/patch, codecov/project, CI / Tests & Coverage and CI / Lint & Format as required checks.

Ref: #305

@Copilot Copilot AI review requested due to automatic review settings June 4, 2025 18:09
@avivkeller avivkeller requested a review from a team as a code owner June 4, 2025 18:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a Codecov configuration to enforce coverage thresholds on pull requests and the overall project.

  • Introduces codecov.yml with patch and project coverage status targets
  • Includes TODOs for raising thresholds once coverage improves

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.90%. Comparing base (42bbad6) to head (c22f9f1).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   41.24%   48.90%   +7.66%     
==========================================
  Files          94       82      -12     
  Lines        7092     6825     -267     
  Branches      211      277      +66     
==========================================
+ Hits         2925     3338     +413     
+ Misses       4164     3484     -680     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller
Copy link
Member Author

This shouldn't land until #307, plus the followup which will get us from 40-ish to 43-ish (so we have a bit of margin)

@AugustinMauroy
Copy link
Member

bump @avivkeller Linting is failing 😃

@avivkeller avivkeller merged commit 440da36 into main Jun 5, 2025
10 checks passed
@avivkeller avivkeller deleted the codecov/checks branch June 5, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants