-
-
Notifications
You must be signed in to change notification settings - Fork 627
feat(trash): add synchronized trash support for windows #2335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(trash): add synchronized trash support for windows #2335
Conversation
or maybe just leave the Hi @alex-courtis , do you have any comments ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
I'm happy with the sync: cautious but reliable behaviour is preferred. We don't need any more options.
What is the actual trash.cmd
? We can set this for windows, as I have just done for macos: #2336
It might be easiest to merge that PR before this one.
Please:
- update help section 10
- update help section 4 nvim-tree.trash.cmd
- test under WSL and powershell (if you haven't already)
hi @alex-courtis , The actual trash.cmd is -------- update -------- Add manual testing screen recording here (Windows 11 arm64 VM running on macOS M1, the trash operation seems very slow but it should the VM performance issue, not nvim-tree or other things): test-on-windows11-v1.mp4I had done 2 kinds of manual testing:
Tasks:
|
RE WSL or WSL2 I'll leave that to you... I'm not familiar with windows. A quick test on whatever is the current WSL would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, many thanks for your contribution.
Test on WSL2 is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your contribution!
fixes #2331
Support trash-cli on Windows, relate to discussion #2333 and #2331.
Unix only
from trash action.detach=false
andjobwait { job }
on Windows to make trash operation sync on Windows. This is because: in my testing/practicing, when setdetach=true
in jobstart, nvim (running in Windows Terminal app) quickly switch to desktop, then switch back to nvim, that makes the screen blink. I guess the process detech behaviour is different under Windows, to avoid this blink I set sync wait under Windows.