fix: trash.cmd defaults to 'trash' on macos

[alex-courtis]

fixes #1366

[gegoune]

Shouldn't that be gio trash?

[alex-courtis]

This is where I get confused. I was under the impression that gio would put the files in ~/.local/share/Trash/files which is not recognised by macos.

Perhaps we should just update the doc, removing "Trash is unavailable" and noting the available homebrew options for macos users.

[alex-courtis]

I think it might be time for me to use https://github.com/sickcodes/Docker-OSX

[kennyishihara]

Here, we found that neither trash nor gio comes preinstalled on macOS so it's best to do what you said, which is to warn the users that D is not available unless you install trash from homebrew. We shouldn't use gio trash on macOS as it moves the file to a different location than ~/.Trash which is where the Bin icon is pointing to.

[alex-courtis]

Updated to include the windows trash changes #2335

• @linrongbin16 what is the value of trash.cmd for windows?

[linrongbin16]

Hi, @alex-courtis, there's no such default trash command on Windows.
People have to install third party command to make it work. For now, the most porpular one is: https://github.com/sindresorhus/trash-cli. The command is just: trash.

For macOS/Linux, I also don't know if there is such a default command. I always install third party via nodejs or python.

[alex-courtis]

Thanks mate. Adding to the doc.

[linrongbin16]

sure thing

[linrongbin16]

lgtm