Skip to content

Add max_interleaving DPC++ FPGA tutorial #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2020
Merged

Add max_interleaving DPC++ FPGA tutorial #171

merged 6 commits into from
Sep 23, 2020

Conversation

citian-intel
Copy link
Contributor

Add max_interleaving DPC++FPGA tutorial

Description

This tutorial demonstrates how to apply the max_interleaving attribute to loops and how it affects loop resource use.

Fixes # (issue)

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Command Line

Add max_interleaving DPC++FPGA tutorial
@citian-intel
Copy link
Contributor Author

@akertesz @AlbyB @pmpeter1 @tomlenth please review.

@tomlenth
Copy link
Contributor

This looks good to me. thank you.

@akertesz
Copy link
Contributor

Your code is written for DPC++ compiler beta10 version. However, we require backwards compatibility with the beta09 compiler until the beta10 version is formally released.

Please add the following code for backwards compatability:

// Header locations and some DPC++ extensions changed between beta09 and beta10
// Temporarily modify the code sample to accept either version
#define BETA09 20200827
#if __SYCL_COMPILER_VERSION <= BETA09
  #include <CL/sycl/intel/fpga_extensions.hpp>
  namespace INTEL = sycl::intel;  // Namespace alias for backward compatibility
#else
  #include <CL/sycl/INTEL/fpga_extensions.hpp>
#endif

You can refer to #167 to see an example of this.

add backwards compatibility with the beta09 compiler
Copy link

@pmpeter1 pmpeter1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing header file location comment above "dpc_common.hpp"

@JoeOster JoeOster requested review from a team, mkitez and sravanikonda and removed request for a team September 21, 2020 22:30
add the comment for #include "dpc_common.hpp" and change the includes in alphetical order
@akertesz akertesz changed the title Signed-off-by: Ci Tian <[email protected]> Add max_interleaving DPC++ FPGA tutorial Sep 22, 2020
Copy link

@pmpeter1 pmpeter1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not be including <CL/sycl.hpp> twice.

remove the extra include of CL/sycl.hpp
pmpeter1
pmpeter1 previously approved these changes Sep 22, 2020
@akertesz
Copy link
Contributor

Windows CI failed -- looks like a basic copy-paste error. Please update your ninja file to reference the correct files!

@akertesz akertesz requested review from akertesz and removed request for a user and sravanikonda September 22, 2020 18:33
akertesz
akertesz previously approved these changes Sep 22, 2020
@akertesz
Copy link
Contributor

Approved to re-launch the CI test

@citian-intel
Copy link
Contributor Author

I have tested the windows flow locally, adding an explicit scope to the sqrt function fix the failures on windows.

Copy link
Contributor

@akertesz akertesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's retrigger the CI test to see whether the sqrt issue is resolved.

@akertesz akertesz removed the request for review from mkitez September 23, 2020 01:45
@akertesz
Copy link
Contributor

Paul's comment is addressed, Tom is satisfied with the README, and CI is passing -- I think we're good to go!

@akertesz akertesz merged commit eb0bafd into oneapi-src:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants