updated vector-add to remove dpc_common.hpp dependency #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jennifer.l.jiang <[email protected]>
Signed-off-by: Jenn500 <[email protected]>
anjgola
suggested changes
Jul 21, 2020
There was a problem hiding this comment.
Please resolve conflicts. Your fork seems out of date. Update it using the section listed at the bottom of this page. Title is 'Sync fork and upstream repository'.
https://github.com/oneapi-src/oneAPI-samples/wiki/Git-Steps-for-Contribution
|
@Jenn500 can you look and fix your conflicts please |
|
please ignore this pull request. a newer pull request without conflicts is created. |
jimmytwei
pushed a commit
to jimmytwei/oneAPI-samples
that referenced
this pull request
Mar 29, 2023
oneapi-src#42) The CMake for the samples use a work-around for linking the SYCL libraries, however this causes failures on Windows due to explicit linking rather than letting the DPC++ driver handle it correctly when passed the -fsycl flag. This commit removes the workaround as it is believed to no longer be needed. Signed-off-by: Larsen, Steffen <[email protected]> Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus changed "rm -rf ..." to "rm -f" in makefiles.
Please review @anjgola, Anton, Roman