Set symbol versions 0.10 in def/map files #1013
Conversation
src/libumf.def
Outdated
| @@ -4,9 +4,9 @@ | |||
| ; SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
| ;;;; End Copyright Notice | |||
|
|
|||
| LIBRARY umf | |||
| LIBRARY LIBUMF | |||
There was a problem hiding this comment.
Changing the name of the library here has consequences..
Creating library D:/a/unified-memory-framework/unified-memory-framework/build/lib/Release/umf.lib and object D:/a/unified-memory-framework/unified-memory-framework/build/lib/Release/umf.exp
umf.exp : warning LNK4070: /OUT:LIBUMF.dll directive in .EXP differs from output filename 'D:\a\unified-memory-framework\unified-memory-framework\build\bin\Release\umf.dll'; ignoring directive [D:\a\unified-memory-framework\unified-memory-framework\build\src\umf.vcxproj]
You should also change project name or change the name of library in src/CMakeLists.txt:141, but another consequence is that you will need to change ALL dependencies around.
| - Update project's version in a few places: | ||
| - For major and minor releases: `UMF_VERSION_CURRENT` in `include/umf/base.h` (the API version) | ||
| - `release` variable in `scripts/docs_config/conf.py` (for docs) | ||
| - `UMF_VERSION` variable in `.github/workflows/basic.yml` (for installation test) | ||
| - For major releases update ABI version in `.map` and `.def` files | ||
| - For major and minor (prior 1.0.0) releases update ABI version in `.map` and `.def` files | ||
| - These files are defined for all public libraries (`libumf` and `proxy_lib`, at the moment) |
There was a problem hiding this comment.
After your changes I believe also proxy_lib will be libproxy_lib, IMO very strange naming, and should be leaved as umf and umf_proxy (e.g. oneTBB convention for tbbmalloc/tbbmalloc_proxy).
|
If you want to change the |
|
@lukaszstolarczuk If we can't keep the current lib name (just umf.dll) with this change, I would opt for leaving UMF_* in map/def as it is, rather than changing it to LIBUMF_* even if we would have UMF_1.0 twice in our history |
lukaszstolarczuk
force-pushed
the
set-symbol-ver
branch
from
5b33442 to
ea7a556
Compare
Co-authored-by: Łukasz Stolarczuk <[email protected]>
lukaszstolarczuk
force-pushed
the
set-symbol-ver
branch
from
ea7a556 to
c0331a4
Compare
and unify names used in these files - "LIBUMF" and "LIBUMF_PROXY"