Skip to content

Set symbol versions 0.10 in def/map files #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Set symbol versions 0.10 in def/map files #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions RELEASE_STEPS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ Do changes for a release:
- If previously we decided not to create such branch, create it now, based on the appropriate minor or major tag
- For major/minor release start from the `main` branch
- Add an entry to ChangeLog, remember to change the day of the week in the release date
- For major releases mention API and ABI compatibility with the previous release
- For major and minor (prior 1.0.0) releases mention API and ABI compatibility with the previous release
- Update project's version in a few places:
- For major and minor releases: `UMF_VERSION_CURRENT` in `include/umf/base.h` (the API version)
- `release` variable in `scripts/docs_config/conf.py` (for docs)
- `UMF_VERSION` variable in `.github/workflows/basic.yml` (for installation test)
- For major releases update ABI version in `.map` and `.def` files
- For major and minor (prior 1.0.0) releases update ABI version in `.map` and `.def` files
- These files are defined for all public libraries (`libumf` and `proxy_lib`, at the moment)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After your changes I believe also proxy_lib will be libproxy_lib, IMO very strange naming, and should be leaved as umf and umf_proxy (e.g. oneTBB convention for tbbmalloc/tbbmalloc_proxy).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

- Commit these changes and tag the release:
- `git commit -a -S -m "$VERSION release"`
Expand Down
4 changes: 2 additions & 2 deletions src/libumf.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
; SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
;;;; End Copyright Notice

LIBRARY umf
LIBRARY UMF

VERSION 1.0
VERSION 0.10

EXPORTS
DllMain
Expand Down
2 changes: 1 addition & 1 deletion src/libumf.map
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

UMF_1.0 {
UMF_0.10 {
global:
umfInit;
umfTearDown;
Expand Down
1 change: 1 addition & 0 deletions src/proxy_lib/proxy_lib.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
;;;; End Copyright Notice

LIBRARY UMF_PROXY

EXPORTS
DllMain
aligned_alloc
Expand Down
4 changes: 2 additions & 2 deletions src/proxy_lib/proxy_lib.map
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
# Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

# linker VERSION script

# These functions are meant to be in unnamed scope. They are also not named
# with any umf prefix, as they should override functions with the same name.
{
global:
aligned_alloc;
Expand Down
Loading