Add sanitizers #121
Merged
Add sanitizers #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswiecicki
force-pushed
the
add-sanitizers
branch
from
5b2af89 to
c11cc0f
Compare
bratpiorka
requested changes
Jan 10, 2024
bratpiorka
reviewed
Jan 10, 2024
bratpiorka
reviewed
Jan 10, 2024
bratpiorka
reviewed
Jan 10, 2024
bratpiorka
reviewed
Jan 10, 2024
bratpiorka
requested changes
Jan 10, 2024
bratpiorka
reviewed
Jan 10, 2024
KFilipek
reviewed
Jan 10, 2024
igchor
approved these changes
Jan 10, 2024
kswiecicki
force-pushed
the
add-sanitizers
branch
5 times, most recently
from
554a2c7 to
a912647
Compare
| @@ -6,6 +6,10 @@ | |||
| # helpers.cmake -- helper functions for top-level CMakeLists.txt | |||
| # | |||
There was a problem hiding this comment.
pls bump dates (in all files)
There was a problem hiding this comment.
not done in the top-level CMakeLists
kswiecicki
force-pushed
the
add-sanitizers
branch
2 times, most recently
from
a2108f2 to
0697694
Compare
bratpiorka
reviewed
Jan 12, 2024
bratpiorka
approved these changes
Jan 12, 2024
PatKamin
approved these changes
Jan 15, 2024
|
@lukaszstolarczuk @KFilipek please resolve your discussions |
|
@kswiecicki please rebase |
ldorau
reviewed
Jan 15, 2024
KFilipek
approved these changes
Jan 15, 2024
|
Last thing, it's an atomic change and please squash your changes. |
ldorau
reviewed
Jan 16, 2024
kswiecicki
force-pushed
the
add-sanitizers
branch
from
0697694 to
1cd17d8
Compare
kswiecicki
force-pushed
the
add-sanitizers
branch
from
1cd17d8 to
77e6aaf
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's a problem with leak reported in jemalloc pool implementation. For this reason sanitizers are temporarily disabled on CI for cases when pool tracking is enabled.
Leak points to some
tracker_value_tnot being freed after being allocated byarena_extent_allocjemalloc extent hook as a part ofumfMemoryProviderAlloccall.Log reported by leak sanitizer: leak.log