ASan workflow fix #154
Merged
ASan workflow fix #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswiecicki
force-pushed
the
asan-workflow-fix
branch
from
2c03589 to
bbb1d5f
Compare
bratpiorka
reviewed
Jan 18, 2024
bratpiorka
reviewed
Jan 18, 2024
bratpiorka
requested changes
Jan 18, 2024
kswiecicki
force-pushed
the
asan-workflow-fix
branch
2 times, most recently
from
6830888 to
e64d0a4
Compare
|
Rebase please |
Due to the changes in running CI jobs in UMF, the sanitizer checks added to the basic.yml workflow file were not tested properly and are currently failing on Windows. For this reason, ASan checks are temporarily disabled on Windows, enabling them requires further investigation.
kswiecicki
force-pushed
the
asan-workflow-fix
branch
from
e64d0a4 to
1a99a28
Compare
bratpiorka
approved these changes
Jan 18, 2024
|
@ldorau @lukaszstolarczuk I need second approve :) |
lukaszstolarczuk
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling ASan for MSVC is more complicated than other compilers and wasn't working correctly. The changes made in #121 were not properly tested by the GHA jobs. To test the changes in
basic.ymlworkflow file on this PR, I've temporarily changed the.github/workflows/pr_push.ymlto retrieve workflow file from my fork.For the time being, enabling ASan workflows on MSVC requires further investigation. Currently, even though CMake positively tests MSVC for ASan support and compiles the UMF project without errors, the UMF tests return
0xc0000135error code which isSTATUS_DLL_NOT_FOUND. Appending thePATHenv var with the directory containing ASan lib (eg.C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.32.31326\bin\Hostx64\x64) changes the error code to0xc0000142which isSTATUS_DLL_INIT_FAILED. I've confirmed that the compiler used to build UMF comes from the same directory as ASan lib.