Skip to content

Fix Valgrind runs #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2024
Merged

Fix Valgrind runs #176

merged 4 commits into from
Jan 30, 2024

Conversation

igchor
Copy link
Member

@igchor igchor commented Jan 25, 2024

No description provided.

@igchor igchor requested a review from a team as a code owner January 25, 2024 20:11
bratpiorka
bratpiorka approved these changes Jan 26, 2024
View reviewed changes
@bratpiorka bratpiorka self-requested a review January 26, 2024 10:43
bratpiorka
bratpiorka previously requested changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@bratpiorka bratpiorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

bratpiorka
bratpiorka reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@bratpiorka bratpiorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others - please review as I'm on vacation

@bratpiorka bratpiorka self-requested a review January 29, 2024 08:50
@igchor igchor mentioned this pull request Jan 29, 2024
Merged
igchor added 4 commits January 29, 2024 18:35
@igchor
Fix maxnode calculation in numa memory target
6ba9300 
It should be set to the highest possible id of a node
(highest bit set in the map) + 1, and not to number
of nodes.
@igchor
Fix ulong number calculation in OS provider
f6a412f 
fix off by 1 error which resulted in reading one too many
longs from the nodemask.
@igchor
Integrate hwloc with valgrind
10392df 
Hwloc requires dumping CPUID before running under valgrind.
@igchor
Workaround a bug in hwloc_bitmap_nr_ulongs in older hwloc versions
03d9be9
ldorau

This comment was marked as outdated.

Sign in to view

lukaszstolarczuk
lukaszstolarczuk approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we're using in CI hwloc in version 2.7.0 which should not require a fix for hwloc_bitmap_nr_ulongs, but we may run valgrind on other OSes, so it's alright.

@lukaszstolarczuk lukaszstolarczuk dismissed bratpiorka’s stale review January 30, 2024 13:39

Rafał's issues resolved + 4 other approvals

@lukaszstolarczuk lukaszstolarczuk merged commit 60bce33 into oneapi-src:main Jan 30, 2024
@igchor igchor deleted the hwloc_valgrind branch January 31, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldorau ldorau ldorau approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

@PatKamin PatKamin PatKamin approved these changes

@kswiecicki kswiecicki kswiecicki approved these changes

@bratpiorka bratpiorka Awaiting requested review from bratpiorka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@igchor @ldorau @bratpiorka @lukaszstolarczuk @PatKamin @kswiecicki