Skip to content

Enable OS provider in builds in the include section #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Jan 26, 2024

Enable OS provider in builds in the include section. All variables have to be set explicitly in the include section. The values set in the matrix section are NOT copied to the include section.

@ldorau ldorau requested a review from a team as a code owner January 26, 2024 13:24
@ldorau
Copy link
Contributor Author

ldorau commented Jan 26, 2024

@PatKamin OS memory provider config tests are failing:
https://github.com/ldorau/unified-memory-framework/actions/runs/7668648729/job/20900907971
@PatKamin could you take a look at this?

@igchor
Copy link
Member

igchor commented Jan 29, 2024

@ldorau can you try rebasing on top of #176? The failure looks similar to the valgrind failures.

@ldorau ldorau force-pushed the Enable_OS_provider_in_builds_in_the_include_section branch from a8e04c6 to f1ec3fe Compare January 29, 2024 15:49
@ldorau
Copy link
Contributor Author

ldorau commented Jan 29, 2024

@ldorau can you try rebasing on top of #176? The failure looks similar to the valgrind failures.

@igchor Done

@ldorau ldorau force-pushed the Enable_OS_provider_in_builds_in_the_include_section branch from f1ec3fe to a4b9214 Compare January 29, 2024 15:52
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait for #176

@ldorau, please rebase

Enable OS provider in builds in the include section.
All variables have to be set explicitly in the include section.
The values set in the matrix section
are NOT copied to the include section.

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Enable_OS_provider_in_builds_in_the_include_section branch from a4b9214 to 078d5b6 Compare January 30, 2024 18:36
@ldorau
Copy link
Contributor Author

ldorau commented Jan 30, 2024

wait for #176

@ldorau, please rebase

@lukaszstolarczuk Rebased.
Done

@igchor igchor merged commit 48b2b4f into oneapi-src:main Jan 30, 2024
@ldorau ldorau deleted the Enable_OS_provider_in_builds_in_the_include_section branch January 30, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants