Skip to content

Add job with Intel C/C++ Compiler #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

KFilipek
Copy link
Contributor

Add job with Intel C/C++ Compiler

Description

This PR introduces Intel C/C++ Compiler provided as a Docker image.

Used VM: Ubuntu 22.04
Used container: intel/oneapi:latest (icx/icpx 2024.02)

Other jobs are VM-based (Ubuntu 20.04/22.04, Windows 2019 or MacOSX) and those runners have other paths (github.workspace etc.) than steps executed under Docker in those VM's.
To avoid ambiguity there is a mounting between host and container.

Notice section

Notice 1:

The privileged option is related to NUMA requirements. Maybe it is possible to limit permission just by "--sys-cap SYS_CAP_NICE", but I don't test this option.

Notice 2:

As we talked, it will be refactored and please keep it in mind during review.

@KFilipek KFilipek added the enhancement New feature or request label Jan 26, 2024
@KFilipek KFilipek self-assigned this Jan 26, 2024
@KFilipek KFilipek requested a review from a team as a code owner January 26, 2024 16:25
@@ -7,6 +7,70 @@ env:
INSTL_DIR : "${{github.workspace}}/build/install-dir"

jobs:
icx-build:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to add icx/icpx as a "include" to ubuntu matrix (similar to clang or gcc-7) if this is possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can extend execution time a little bit, but I can do it on another PR.

@KFilipek KFilipek force-pushed the task-icx_enablement branch from 6b6fe26 to ff3a5e0 Compare January 27, 2024 17:17
Signed-off-by: Krzysztof Filipek <[email protected]>
This commit fixes following:
error: a function declaration without a prototype is
deprecated in all versions of C [-Werror,-Wstrict-prototypes]

Signed-off-by: Krzysztof Filipek <[email protected]>
@KFilipek KFilipek force-pushed the task-icx_enablement branch from ff3a5e0 to 547b73c Compare January 27, 2024 17:41
@lukaszstolarczuk
Copy link
Contributor

lukaszstolarczuk commented Jan 29, 2024

Notice 2:

As we talked, it will be refactored and please keep it in mind during review.

What do you mean exactly by that second notice?

@KFilipek
Copy link
Contributor Author

Notice 2:

As we talked, it will be refactored and please keep it in mind during review.

What do you mean exactly by that second notice?

As we agreed in the last meeting, workflow files need some refactoring.

@lukaszstolarczuk
Copy link
Contributor

Notice 2:

As we talked, it will be refactored and please keep it in mind during review.

What do you mean exactly by that second notice?

As we agreed in the last meeting, workflow files need some refactoring.

heh, you didn't give me much more details 😄

@lukaszstolarczuk lukaszstolarczuk merged commit 58d0d13 into oneapi-src:main Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants