Skip to content

Add job with Intel C/C++ Compiler #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Add job with Intel C/C++ Compiler #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3227c89
Add job with icx/icpx compiler
KFilipek Jan 26, 2024
547b73c
Fix strict C icx error in base alloc test
KFilipek Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .github/workflows/basic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,70 @@ env:
INSTL_DIR : "${{github.workspace}}/build/install-dir"

jobs:
icx-build:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to add icx/icpx as a "include" to ubuntu matrix (similar to clang or gcc-7) if this is possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can extend execution time a little bit, but I can do it on another PR.

name: Build - Intel C++ Compiler
strategy:
matrix:
build_type: [Debug, Release]
compiler: [{c: icx, cxx: icpx}]
pool_tracking: ['ON', 'OFF']
shared_library: ['OFF']
os_provider: ['ON']
sanitizers: [{asan: OFF, ubsan: OFF, tsan: OFF}]
runs-on: ubuntu-22.04
container:
image: intel/oneapi:latest
volumes:
- ${{github.workspace}}:${{github.workspace}}
options: "--privileged"

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Install apt packages
run: |
apt-get update
apt-get install -y libnuma-dev libjemalloc-dev libtbb-dev libhwloc-dev

- name: Configure build
run: >
cmake
-B build
-DCMAKE_INSTALL_PREFIX="${{env.INSTL_DIR}}"
-DCMAKE_BUILD_TYPE=${{matrix.build_type}}
-DUMF_BUILD_SHARED_LIBRARY=${{matrix.shared_library}}
-DCMAKE_C_COMPILER=${{matrix.compiler.c}}
-DCMAKE_CXX_COMPILER=${{matrix.compiler.cxx}}
-DUMF_BUILD_OS_MEMORY_PROVIDER=${{matrix.os_provider}}
-DUMF_ENABLE_POOL_TRACKING=${{matrix.pool_tracking}}
-DUMF_FORMAT_CODE_STYLE=OFF
-DUMF_DEVELOPER_MODE=ON
-DUMF_BUILD_LIBUMF_POOL_JEMALLOC=ON
-DUMF_BUILD_LIBUMF_POOL_DISJOINT=ON
-DUMF_BUILD_LIBUMF_POOL_SCALABLE=ON
-DUSE_ASAN=${{matrix.sanitizers.asan}}
-DUSE_UBSAN=${{matrix.sanitizers.ubsan}}
-DUSE_TSAN=${{matrix.sanitizers.tsan}}

- name: Build UMF
run: |
cmake --build build -j $(nproc)

- name: Run tests
working-directory: ${{github.workspace}}/build
run: |
ctest --output-on-failure

- name: Test make install
working-directory: ${{env.BUILD_DIR}}
run: ${{github.workspace}}/test/test_make_install.sh \
${{github.workspace}} ${{env.BUILD_DIR}} ${{env.INSTL_DIR}} ${{matrix.build_type}} ${{matrix.shared_library}}

- name: Test make uninstall
working-directory: ${{env.BUILD_DIR}}
run: ${{github.workspace}}/test/test_make_uninstall.sh ${{github.workspace}} ${{env.BUILD_DIR}} ${{env.INSTL_DIR}}

ubuntu-build:
name: Build - Ubuntu
strategy:
Expand Down
2 changes: 1 addition & 1 deletion test/test_base_alloc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ static void *start_routine(void *arg) {
return NULL;
}

int main() {
int main(void) {
pthread_t thread[NTHREADS];
umf_ba_pool_t *pool = umf_ba_create(ALLOCATION_SIZE);

Expand Down