Don't use CodeQL in reusable workflow #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to lower score on Scorecard we'll be running this separately from "PR/push" workflow. For some reason permissions weren't properly set or recognized (by Scorecard). If Scorecard changes its behavior we can go back to use 'workflow_call' trigger.
PatKamin
approved these changes
Feb 8, 2024
bratpiorka
approved these changes
Feb 8, 2024
|
so this is all about setting securityEvents permissions to write? |
Yes, this change is necessary to achieve the required scorecard result in Q1. In the case of using reusable workflows scorecard did not allow setting "write" at the job level. It is hard for me to say whether it is a bug or a feature :) We decided to make the simplest and fastest change that will improve our score. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to lower score on Scorecard we'll be running this separately from "PR/push" workflow. For some reason permissions weren't properly set or recognized (by Scorecard). If Scorecard changes its behavior we can go back to use 'workflow_call' trigger.
// I verified this fixes the "Token-permission" issue on my fork.