Skip to content

Don't use CodeQL in reusable workflow #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Don't use CodeQL in reusable workflow #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: CodeQL

on: workflow_call
# Due to lower score on Scorecard we're running this separately from
# "PR/push" workflow. For some reason permissions weren't properly set
# or recognized (by Scorecard). If Scorecard changes its behavior we can
# go back to use 'workflow_call' trigger.
on: [push, pull_request]

permissions:
contents: read
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/pr_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,3 @@ jobs:
Benchmark:
needs: [Build]
uses: ./.github/workflows/benchmarks.yml
CodeQL:
permissions:
contents: read
security-events: write
needs: [Build]
uses: ./.github/workflows/codeql.yml