Skip to content

Unify benchmarks' CI workflows for Linux and Windows #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Mar 6, 2024

Unify benchmarks' CI workflows for Linux and Windows.
Use ctest to run benchmarks.

A benchmark passes if it prints "PASSED" in the output,
because ubench of scalable pool fails if the confidence interval
exceeds maximum permitted 2.5%.

Fixes: #301

@ldorau ldorau requested a review from a team as a code owner March 6, 2024 14:29
@ldorau ldorau force-pushed the Unify_benchmarks_CI_workflows_for_Linux_and_Windows branch 2 times, most recently from 6169483 to 43b1b32 Compare March 7, 2024 08:32
@ldorau ldorau force-pushed the Unify_benchmarks_CI_workflows_for_Linux_and_Windows branch from 43b1b32 to 8903010 Compare March 7, 2024 11:29
@ldorau ldorau requested a review from bratpiorka March 7, 2024 11:29
@ldorau ldorau force-pushed the Unify_benchmarks_CI_workflows_for_Linux_and_Windows branch from 8903010 to d0e8a78 Compare March 7, 2024 11:36
@ldorau ldorau requested a review from lukaszstolarczuk March 7, 2024 11:38
@ldorau
Copy link
Contributor Author

ldorau commented Mar 7, 2024

@bratpiorka Done
@lukaszstolarczuk Done

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Unify_benchmarks_CI_workflows_for_Linux_and_Windows branch from d0e8a78 to 3f459a1 Compare March 7, 2024 18:10
@ldorau ldorau force-pushed the Unify_benchmarks_CI_workflows_for_Linux_and_Windows branch from 3f459a1 to 25e0154 Compare March 7, 2024 18:20
Unify benchmarks' CI workflows for Linux and Windows.
Use ctest to run benchmarks.

A benchmark passes if it prints "PASSED" in the output,
because ubench of scalable pool fails if the confidence interval
exceeds maximum permitted 2.5%.

Fixes: oneapi-src#301

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Unify_benchmarks_CI_workflows_for_Linux_and_Windows branch from 25e0154 to d67f2f6 Compare March 7, 2024 20:31
@ldorau
Copy link
Contributor Author

ldorau commented Mar 8, 2024

@bratpiorka please re-review

@lukaszstolarczuk lukaszstolarczuk merged commit a045006 into oneapi-src:main Mar 8, 2024
@ldorau ldorau deleted the Unify_benchmarks_CI_workflows_for_Linux_and_Windows branch March 8, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The multithread_bench benchmark does not build on Windows
3 participants