Skip to content

Fix multithreaded bench compilation on windows #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix multithreaded bench compilation on windows #305

merged 1 commit into from
Mar 7, 2024

Conversation

igchor
Copy link
Member

@igchor igchor commented Mar 6, 2024

Fixes: #301

@igchor igchor requested a review from a team as a code owner March 6, 2024 22:36
@bratpiorka
Copy link
Contributor

please add also the changes that enables BUILD_BENCHMARKS_MT on windows in our CI

@ldorau
Copy link
Contributor

ldorau commented Mar 7, 2024

please add also the changes that enables BUILD_BENCHMARKS_MT on windows in our CI

@bratpiorka Here you have all-in-one done: #300

@bratpiorka
Copy link
Contributor

@bratpiorka Here you have all-in-one done: #300

ok, thanks, LGTM

@bratpiorka bratpiorka merged commit 74721b2 into oneapi-src:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The multithread_bench benchmark does not build on Windows
4 participants
@igchor @bratpiorka @ldorau @lukaszstolarczuk