Fix uninstallation random failures on Windows #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswiecicki
approved these changes
Mar 26, 2024
bratpiorka
approved these changes
Mar 26, 2024
bratpiorka
reviewed
Mar 26, 2024
PatKamin
force-pushed
the
fix-uninstallation-test
branch
from
6957065 to
60f76be
Compare
ldorau
previously requested changes
Mar 27, 2024
On Windows, the 'uninstall' target failed randomly. The CMake command used for deleting files, 'cmake -E remove' seems to be not reliable. Changing the command used for files deletion to 'FILE(REMOVE ...)'.
PatKamin
force-pushed
the
fix-uninstallation-test
branch
from
60f76be to
cb36c43
Compare
bratpiorka
approved these changes
Mar 29, 2024
lukaszstolarczuk
approved these changes
Mar 29, 2024
lukaszstolarczuk
dismissed
ldorau’s stale review
Issue resolved, 2 other approves given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Windows, the 'uninstall' target failed randomly. The CMake command used for deleting files, 'cmake -E remove' seems to be not reliable. Changing the tool used for files deletion to 'rm'.
Checklist