-
Notifications
You must be signed in to change notification settings - Fork 35
Disable proxy lib tests on Windows Debug #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable proxy lib tests on Windows Debug #401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now you have to add the -C
option to all ctest
calls, even on Linux! Because this
$ ctest
will NOT run the proxy library tests, only that:
$ ctest -C Release
will do.
3a7a016
to
124b5ef
Compare
I think we shouldn't bother with this right now. I hope we'll fix the problems with debug proxy lib in the future and then we could remove this code. |
OK |
but I see the CI pass? |
Yes, in CI we explicitly use the |
Now the behavior is the same regardless of the platform, one have to add the |
The proxy library tests are not run on Linux now!: |
But not in Linux jobs! - it has to be added there. |
124b5ef
to
b263130
Compare
Thanks, I hadn't noticed that. I've removed the list of configs from the linux builds so there should be no impact of this change on linux tests now. |
b263130
to
92fa419
Compare
Description
Fixes: #399
This PR disables the two tests which use proxy lib when ctest is run for a Debug config on Windows:
Checklist