Skip to content

Test the shared version of the UMF library on Windows #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Apr 2, 2024

Description

Test the shared version of the UMF library on Windows.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@PatKamin
Copy link
Contributor

PatKamin commented Apr 2, 2024

Please, try running the tests with the changes from #401

@ldorau ldorau force-pushed the Test_the_shared_version_of_the_UMF_library_on_Windows branch 2 times, most recently from 258d1f5 to bc09ab8 Compare April 3, 2024 09:06
@lukaszstolarczuk
Copy link
Contributor

you can rebase, Patryk's change has been merged now :)

@ldorau ldorau force-pushed the Test_the_shared_version_of_the_UMF_library_on_Windows branch from bc09ab8 to 82d1f31 Compare April 3, 2024 10:27
@ldorau ldorau marked this pull request as ready for review April 3, 2024 10:28
@ldorau
Copy link
Contributor Author

ldorau commented Apr 3, 2024

you can rebase, Patryk's change has been merged now :)

@lukaszstolarczuk Done

@ldorau ldorau force-pushed the Test_the_shared_version_of_the_UMF_library_on_Windows branch from 82d1f31 to 233f4ce Compare April 3, 2024 13:50
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lukaszstolarczuk lukaszstolarczuk merged commit c75dd86 into oneapi-src:main Apr 4, 2024
@ldorau ldorau deleted the Test_the_shared_version_of_the_UMF_library_on_Windows branch April 4, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants