Enable gcov #511
Merged
Enable gcov #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
requested changes
May 23, 2024
| @@ -104,6 +104,12 @@ function(add_umf_target_compile_options name) | |||
| ${name} PRIVATE -Werror -fno-omit-frame-pointer | |||
| -fstack-protector-strong) | |||
| endif() | |||
| if(USE_GCOV) | |||
| if(NOT CMAKE_BUILD_TYPE STREQUAL "Debug") | |||
| message(FATAL_ERROR "To use gcov, the build type must be Debug") | |||
There was a problem hiding this comment.
is it truly a fatal error? I guess we get a different results for Release, but it should work, right...?
There was a problem hiding this comment.
From the Clang documentation:
gcov - A GCC-compatible coverage implementation which operates on DebugInfo. This is enabled by -ftest-coverage or --coverage.
There was a problem hiding this comment.
Soo.. it might work in the build type "RelWithDebInfo"...?
KFilipek
force-pushed
the
gcov_enable
branch
2 times, most recently
from
2d25e3e to
d409573
Compare
This commit introduces the option to enable gcov support in the build system. The USE_GCOV option has been added to allow gcov instrumentation.
bratpiorka
approved these changes
May 24, 2024
|
pls don't treat my last issue as a blocker 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces support for gcov, a test coverage program that developers can use to assess the effectiveness of their test suites. The changes include:
With these changes, contributors can now enable gcov support in their debug builds to generate coverage reports, helping to maintain and improve the quality of the test suite.
Checklist