Skip to content

Add static linking option #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

KFilipek
Copy link
Contributor

@KFilipek KFilipek commented Jun 6, 2024

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@KFilipek KFilipek added the enhancement New feature or request label Jun 6, 2024
@KFilipek KFilipek self-assigned this Jun 6, 2024
@KFilipek KFilipek force-pushed the static_linking branch 7 times, most recently from 58dbac5 to 4bd4ba3 Compare June 11, 2024 11:49
@KFilipek KFilipek marked this pull request as ready for review June 11, 2024 20:14
@KFilipek KFilipek requested a review from a team as a code owner June 11, 2024 20:14
@bratpiorka
Copy link
Contributor

bratpiorka commented Jun 12, 2024

Please remove hwloc from your vcpackage installation if it is fetched and built by us. I think we could use a separate version of vcpkg.json

@KFilipek KFilipek force-pushed the static_linking branch 2 times, most recently from 89928ce to ce0b209 Compare June 14, 2024 13:35
@igchor
Copy link
Member

igchor commented Jun 14, 2024

@KFilipek could you add a test for this? (probably adding a job with -DUMF_LINK_HWLOC_STATICALLY=1 -DUMF_BUILD_SHARED_LIBRARY=OFF would be enough) I would like to see if having a binary that links to UMF statically works fine with UMF_LINK_HWLOC_STATICALLY set to 1. As I wrote in #513 I'm not sure if this will work straight away. If there are some tweaks needed, it would be good to know that.

@KFilipek KFilipek force-pushed the static_linking branch 7 times, most recently from dcf58e1 to 1403be7 Compare June 14, 2024 18:19
@igchor
Copy link
Member

igchor commented Jun 17, 2024

@KFilipek could you add a test for this? (probably adding a job with -DUMF_LINK_HWLOC_STATICALLY=1 -DUMF_BUILD_SHARED_LIBRARY=OFF would be enough) I would like to see if having a binary that links to UMF statically works fine with UMF_LINK_HWLOC_STATICALLY set to 1. As I wrote in #513 I'm not sure if this will work straight away. If there are some tweaks needed, it would be good to know that.

@KFilipek It seems like this test scenario was removed in the latest push. Can you enable this again?

@KFilipek KFilipek force-pushed the static_linking branch 2 times, most recently from 695b298 to f465869 Compare June 24, 2024 14:02
@KFilipek KFilipek force-pushed the static_linking branch 6 times, most recently from 28e55c1 to f174536 Compare June 26, 2024 10:18
@KFilipek KFilipek force-pushed the static_linking branch 3 times, most recently from 26106ba to 609345e Compare June 26, 2024 14:20
@KFilipek KFilipek merged commit 2e09eeb into oneapi-src:main Jun 27, 2024
73 checks passed
@KFilipek KFilipek deleted the static_linking branch June 27, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants