load DLLs only from safe load list #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_dll_safe_load_list
branch
30 times, most recently
from
1353c92 to
899f11d
Compare
bratpiorka
force-pushed
the
rrudnick_dll_safe_load_list
branch
7 times, most recently
from
c143e63 to
d8c76c3
Compare
PatKamin
reviewed
Jun 18, 2024
bratpiorka
force-pushed
the
rrudnick_dll_safe_load_list
branch
9 times, most recently
from
6e9275f to
589bb23
Compare
PatKamin
reviewed
Jun 19, 2024
cmake/helpers.cmake
Outdated
| message(STATUS "C_COMPILER_ID: ${C_COMPILER_ID}") | ||
| message(STATUS "CXX_COMPILER_ID: ${CXX_COMPILER_ID}") | ||
| message(STATUS "CMAKE_C_COMPILER_ID: ${CMAKE_C_COMPILER_ID}") | ||
| message(STATUS "CMAKE_CXX_COMPILER_ID: ${CMAKE_CXX_COMPILER_ID}") |
There was a problem hiding this comment.
nit: These messages potentially can be useful for other CMake generators. Could you move them to some common space, maybe in the main CMakeLists.txt?
There was a problem hiding this comment.
these were only debug prints - removed
PatKamin
approved these changes
Jun 19, 2024
lplewa
reviewed
Jun 21, 2024
bratpiorka
force-pushed
the
rrudnick_dll_safe_load_list
branch
3 times, most recently
from
c5421f8 to
5b3b0ed
Compare
bratpiorka
force-pushed
the
rrudnick_dll_safe_load_list
branch
from
5b3b0ed to
0b04e14
Compare
lplewa
approved these changes
Jun 27, 2024
bratpiorka
force-pushed
the
rrudnick_dll_safe_load_list
branch
from
0b04e14 to
38e126e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set /DEPENDENTLOADFLAG to 2000 (LOAD_LIBRARY_SAFE_CURRENT_DIRS) in Windows umf.dll builds (MSVC only).
With this flag, loading a DLL for execution from the current directory is only allowed if it is under a directory in the Safe load list.
In addition, there is a new test written in Power Shell that uses dumpbin.exe to check that this flag is set correctly.
Detailed information about the flag can be found at: https://learn.microsoft.com/en-us/cpp/build/reference/dependentloadflag?view=msvc-170
and: https://learn.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-loadlibraryexa