Add disable_provider_free parameter to pool jemalloc #618
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
requested changes
Jul 17, 2024
ldorau
force-pushed
the
Add_provider_free_always_fails_parameter_to_pool_jemalloc
branch
from
76af328 to
c197f44
Compare
ldorau
changed the title
ldorau
force-pushed
the
Add_provider_free_always_fails_parameter_to_pool_jemalloc
branch
from
c197f44 to
8e8db44
Compare
bratpiorka
approved these changes
Jul 17, 2024
Add the disable_provider_free parameter to pool jemalloc. It should be set to true if umfMemoryProviderFree() should never be called. This option will be needed by the future memory providers that will not provide the free() op. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_provider_free_always_fails_parameter_to_pool_jemalloc
branch
from
8e8db44 to
996273c
Compare
KFilipek
reviewed
Jul 17, 2024
KFilipek
approved these changes
Jul 18, 2024
ldorau
deleted the
Add_provider_free_always_fails_parameter_to_pool_jemalloc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the
disable_provider_freeparameter to pool jemalloc. It should be set to true ifumfMemoryProviderFree()should never be called.This option will be needed by the future memory providers that will not provide the free() op.
Checklist