Skip to content

Add option to control fetching L0 #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

igchor
Copy link
Member

@igchor igchor commented Aug 15, 2024

Turning UMF_BUILD_LEVEL_ZERO_PROVIDER on in UR
results in configuration errors as both projects try to fetch and build L0 loader.

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@igchor igchor requested a review from a team as a code owner August 15, 2024 21:48
@igchor igchor marked this pull request as draft August 15, 2024 21:50
@igchor igchor marked this pull request as ready for review August 15, 2024 22:33
@bratpiorka
Copy link
Contributor

@igchor is this needed for 2025.0? AFAIK UR would not use L0 provider from UMF in 2025.0?

@igchor
Copy link
Member Author

igchor commented Aug 19, 2024

@igchor is this needed for 2025.0? AFAIK UR would not use L0 provider from UMF in 2025.0?

No, it's not for 2025.0. I'm working on L0 v2 adapter (https://github.com/oneapi-src/unified-runtime/tree/main/source/adapters/level_zero/v2) and I'd rather use UMF instead of duplicating the original logic for USM. We would still need to implement missing features (at least support for making the memory resident) but that shouldn't be too difficult.

@igchor
Copy link
Member Author

igchor commented Aug 23, 2024

@bratpiorka @lukaszstolarczuk Ok, I did it slightly differently. Since we only need loader for tests (and example, but they have separate fetch_content) we can just add option to set UMF_LEVEL_ZERO_INCLUDE_DIR. If this option is set and we don't need the loader, we can skip fetching L0. UR actually have a similar mechanism with UR_LEVEL_ZERO_INCLUDE_DIR

Turning UMF_BUILD_LEVEL_ZERO_PROVIDER on in UR
results in configuration errors as both projects try
to fetch and build L0 loader.
@igchor
Copy link
Member Author

igchor commented Aug 23, 2024

@lukaszstolarczuk do you know why the GPU tests are failing on CI? it works for me locally

@lukaszstolarczuk
Copy link
Contributor

@lukaszstolarczuk do you know why the GPU tests are failing on CI? it works for me locally

I think it's the issue with the machine, it should be fixed by now. I've hit re-run.

@igchor igchor marked this pull request as draft August 23, 2024 21:43
@igchor igchor marked this pull request as ready for review August 26, 2024 21:20
@igchor
Copy link
Member Author

igchor commented Aug 26, 2024

@bratpiorka @lukaszstolarczuk are you OK with this solution? I've made a draft PR to UR to test this: oneapi-src/unified-runtime#2012

@lukaszstolarczuk lukaszstolarczuk merged commit 1b09fd1 into oneapi-src:main Aug 27, 2024
65 checks passed
@igchor igchor deleted the fetch_l0 branch August 27, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants