Skip to content

[L0 v2] Use L0 provider from UMF and bump UMF tag #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

igchor
Copy link
Member

@igchor igchor commented Aug 26, 2024

Move L0 fetching to the CMakeLists.txt in common:
L0 needs to be fetched before UMF.

@github-actions github-actions bot added common Changes or additions to common utilities level-zero L0 adapter specific issues labels Aug 26, 2024
@igchor igchor marked this pull request as ready for review August 27, 2024 23:21
@igchor igchor requested review from a team as code owners August 27, 2024 23:21
@igchor igchor changed the title [L0 v2] Use L0 provider from UMF [L0 v2] Use L0 provider from UMF and bump UMF tag Aug 27, 2024
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukaszstolarczuk
Copy link
Contributor

I guess you should re-base, and BTW you could bump umf with your latest changes: oneapi-src/unified-memory-framework#703

Move L0 fetching to the CMakeLists.txt in common:
L0 needs to be fetched before UMF.
as PATH should be used when pointing to a drirectory
@igchor
Copy link
Member Author

igchor commented Sep 3, 2024

I guess you should re-base, and BTW you could bump umf with your latest changes: oneapi-src/unified-memory-framework#703

Done.

@igchor igchor marked this pull request as draft September 4, 2024 16:21
@igchor igchor closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Changes or additions to common utilities level-zero L0 adapter specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants