add introduction to docs #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_doc_ext
branch
from
46cedc5 to
103f3a8
Compare
|
here's what the new pages look like: https://bratpiorka.github.io/unified-memory-framework/introduction.html |
bratpiorka
force-pushed
the
rrudnick_doc_ext
branch
2 times, most recently
from
f980b7e to
56ef5d8
Compare
igchor
reviewed
Dec 20, 2023
PatKamin
reviewed
Dec 20, 2023
PatKamin
reviewed
Dec 20, 2023
DamianDuy
reviewed
Dec 28, 2023
kswiecicki
reviewed
Dec 28, 2023
scripts/docs_config/introduction.rst
Outdated
|
|
||
| The amount of data associated with modern workloads that need to be processed | ||
| by modern workloads is continuously growing. To address the increasing demand | ||
| memory subsystem of modern server platforms is becoming heterogeneous. For |
There was a problem hiding this comment.
It's difficult to read this without a comma. To address this increasing demand, the memory subsystem of ...
bratpiorka
force-pushed
the
rrudnick_doc_ext
branch
3 times, most recently
from
bb14dd1 to
e6d50d2
Compare
vinser52
reviewed
Jan 10, 2024
igchor
reviewed
Jan 10, 2024
bratpiorka
force-pushed
the
rrudnick_doc_ext
branch
from
e6d50d2 to
ddd68ef
Compare
vinser52
requested changes
Jan 12, 2024
bratpiorka
force-pushed
the
rrudnick_doc_ext
branch
5 times, most recently
from
3770256 to
8822c0c
Compare
bratpiorka
requested review from
igchor,
DamianDuy,
PatKamin,
vinser52 and
kswiecicki
|
@igchor @PatKamin @DamianDuy @vinser52 @kswiecicki - all, we got > 100 comments here :) I updated the documentation with your suggestions - please resolve all conversations that are ok. |
vinser52
reviewed
Jan 15, 2024
PatKamin
reviewed
Jan 16, 2024
bratpiorka
force-pushed
the
rrudnick_doc_ext
branch
from
8822c0c to
1083480
Compare
vinser52
approved these changes
Jan 16, 2024
PatKamin
approved these changes
Jan 16, 2024
lukaszstolarczuk
requested changes
Jan 16, 2024
| @@ -15,7 +15,9 @@ A UMF memory pool is a combination of a pool allocator and a memory provider. A | |||
|
|
|||
| Pool allocator can leverage existing allocators (e.g. jemalloc or tbbmalloc) or be written from scratch. | |||
|
|
|||
| UMF comes with predefined pool allocators (see include/pool) and providers (see include/provider). UMF can also work with user-defined pools and providers that implement a specific interface (see include/umf/memory_pool_ops.h and include/umf/memory_provider_ops.h) | |||
| UMF comes with predefined pool allocators (see include/pool) and providers (see include/provider). UMF can also work with user-defined pools and providers that implement a specific interface (see include/umf/memory_pool_ops.h and include/umf/memory_provider_ops.h). | |||
There was a problem hiding this comment.
nit: you can add links in repo to these file:
... (see [include/umf/memory_pool_ops.h](include/umf/memory_pool_ops.h) and [include/umf/memory_provider_ops.h](include/umf/memory_provider_ops.h) ).
kswiecicki
approved these changes
Jan 16, 2024
igchor
approved these changes
Jan 16, 2024
bratpiorka
force-pushed
the
rrudnick_doc_ext
branch
from
1083480 to
69eccd1
Compare
lukaszstolarczuk
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.