Skip to content

[CI] New workflows order part1 #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 17, 2024
Merged

[CI] New workflows order part1 #791

merged 7 commits into from
Oct 17, 2024

Conversation

lukaszstolarczuk
Copy link
Contributor

Please review each commit separately. Verified on my fork it all works as expected.

Notes:

  • Unfortunately currently GHA does not support sub-dirs in .github/workflows directory.
  • Scorecard is not giving a penalty now for reusable workflows with higher permissions.

Checklist

  • CI workflows execute properly

@lukaszstolarczuk lukaszstolarczuk requested a review from a team as a code owner October 10, 2024 13:36
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@lukaszstolarczuk lukaszstolarczuk force-pushed the order-ci-pt1 branch 2 times, most recently from 7178d9d to 17f8762 Compare October 16, 2024 11:15
@ldorau @lukaszstolarczuk
[CI] Fix all pip installations
10b9391 
Latest distros do not allow global pip installation.
Python packages have to be installed in venv, on Linux.

Signed-off-by: Lukasz Dorau <[email protected]>
@lplewa lplewa changed the title [CI] Order in workflows part1 [CI] New workflows order part1 Oct 16, 2024
@lukaszstolarczuk
Copy link
Contributor Author

Code coverage did not change - still 80,1% - sounds like I didn't break anything with this change :)

ldorau
ldorau approved these changes Oct 17, 2024
View reviewed changes
.github/workflows/reusable_valgrind.yml
@@ -1,3 +1,4 @@
# Run tests with valgrind intstrumentation tools: memcheck, drd, helgrind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intstrumentation -> instrumentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix that in the next PR; I'd like to omit waiting for the whole CI to re-run 😄

@lukaszstolarczuk lukaszstolarczuk merged commit 0c82ae5 into oneapi-src:main Oct 17, 2024
74 checks passed
@lukaszstolarczuk lukaszstolarczuk deleted the order-ci-pt1 branch October 17, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldorau ldorau ldorau approved these changes

@PatKamin PatKamin PatKamin approved these changes

@bratpiorka bratpiorka Awaiting requested review from bratpiorka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszstolarczuk @ldorau @PatKamin