Make sure pointers are correctly aligned in os_mmap_aligned() #84
Conversation
ldorau
force-pushed
the
Make_sure_pointers_are_correctly_aligned_in_os_mmap_aligned
branch
from
58d296a to
23a96a5
Compare
|
|
||
| size_t head_len = aligned_addr - addr; | ||
| if (head_len > 0) { | ||
| // head_len has to be page-aligned, because aligned_addr has to be page-aligned | ||
| assert_is_page_aligned(head_len, page_size); |
There was a problem hiding this comment.
Why do we just crash? Assert indicates a mistake in the code logic. Is this condition only possible by mistake? what if the page size 4kb and the requested alignment 6kb?
There was a problem hiding this comment.
BTW tests added in a separate PR: #93
There was a problem hiding this comment.
I still only see asserts and not the INVALID_ARGUMENT error code.
There was a problem hiding this comment.
Assert indicates a mistake in the code logic. Those conditions are possible only by mistake.
There was a problem hiding this comment.
I meant those asserts verify if os_alloc() passed a correct alignment. A user cannot trigger them changing the input alignment. All required checks are done in os_alloc() and os_alloc() passes only a correct alignment to this function. So IMHO those asserts are correct.
There was a problem hiding this comment.
Ah yes, sorry, I missed the PR that changed the checks in os_alloc.
ldorau
force-pushed
the
Make_sure_pointers_are_correctly_aligned_in_os_mmap_aligned
branch
from
c834b71 to
192d1df
Compare
|
Requires: |
Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Make_sure_pointers_are_correctly_aligned_in_os_mmap_aligned
branch
from
192d1df to
f3ede04
Compare
|
Rebased |
ldorau
deleted the
Make_sure_pointers_are_correctly_aligned_in_os_mmap_aligned
branch
Ref: #74 (comment)