Add tests for alignment in OS memory provider #93
+154
−302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Add_tests_for_alignment_in_OS_memory_provider
branch
5 times, most recently
from
1424c1e to
c425f01
Compare
|
Add tests for alignment in OS memory provider and refactor tests to use gtest's |
ldorau
force-pushed
the
Add_tests_for_alignment_in_OS_memory_provider
branch
from
c425f01 to
9d818ee
Compare
igchor
approved these changes
Dec 28, 2023
test/provider_os_memory.cpp
Outdated
| // wrong NUMA flags | ||
| os_memory_provider_params.numa_flags = (unsigned int)-1; | ||
| // capture provider and destroy it | ||
| auto providerDestructor = [](umf_memory_provider_handle_t hProvider) { |
There was a problem hiding this comment.
nit: you don't need to create a custom destructor here, you can just pass umfMemoryProviderDestroy directly to unique_ptr ctor, like this: return umf::provider_unique_handle_t(hProvider, &umfMemoryProviderDestroy);
This was needed for poolCreateExt because we wanted to destroy both pool and provider at the same time.
test/provider_os_memory.cpp
Outdated
| ASSERT_EQ(umf_result, UMF_RESULT_SUCCESS); | ||
| ASSERT_NE(os_memory_provider, nullptr); | ||
| ASSERT_LE(min_page_size, SIZE_4100); |
There was a problem hiding this comment.
Why compare with 4100? Should we even have a hardcoded page size here? There can be some systems with different page sizes right?
|
@igchor review again, please |
ldorau
force-pushed
the
Add_tests_for_alignment_in_OS_memory_provider
branch
2 times, most recently
from
a8813e9 to
b0552b8
Compare
Add tests for alignment in OS memory provider and refactor tests to use gtest's TEST_P(). Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_tests_for_alignment_in_OS_memory_provider
branch
from
b0552b8 to
d611e28
Compare
bratpiorka
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for alignment in OS memory provider and refactor tests to use gtest's
TEST_P().