Skip to content

Fix Level Zero related CMake configs #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

vinser52
Copy link
Contributor

@vinser52 vinser52 commented Nov 5, 2024

Description

There are two L0-related fixes in this PR:

  1. When UMF_LEVEL_ZERO_INCLUDE_DIR is set the test cannot be built because of ze_api.h not found. It happens because we set LEVEL_ZERO_INCLUDE_DIRS in the src/CMakeLists.txt. The fix moves corresponding CMake code to the ./CmakeLists.txt. @lukaszstolarczuk, @bratpiorka, looks like we never checked such flow in CI, can we do that?
  2. Some versions of the L0 driver do not return an error when a user tries to allocate 0 bytes. So I removed the corresponding test.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@vinser52 vinser52 requested a review from a team as a code owner November 5, 2024 22:38
@vinser52 vinser52 changed the title Svinogra fix l0 Fix Level Zero related CMake configs Nov 5, 2024
@lukaszstolarczuk lukaszstolarczuk merged commit f607b03 into oneapi-src:main Nov 7, 2024
74 checks passed
@vinser52 vinser52 deleted the svinogra_fix_l0 branch February 4, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants