Skip to content

Enable -Werror flag in developer build #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

staniewzki
Copy link
Contributor

@staniewzki staniewzki commented Nov 12, 2024

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@staniewzki staniewzki force-pushed the enable-werror branch 6 times, most recently from e58141d to 3b449cd Compare November 13, 2024 09:36
@staniewzki staniewzki force-pushed the enable-werror branch 10 times, most recently from 7a7b552 to 60e4d47 Compare November 19, 2024 10:03
@ldorau
Copy link
Contributor

ldorau commented Nov 19, 2024

@staniewzki please test your PR on your private fork until all CI tests pass

@ldorau
Copy link
Contributor

ldorau commented Nov 19, 2024

Please rebase again, there are conflicts.

@staniewzki staniewzki force-pushed the enable-werror branch 2 times, most recently from 8f2f4eb to 71be641 Compare November 20, 2024 09:34
@staniewzki staniewzki changed the title [WIP] Enable -Werror flag in developer build Enable -Werror flag in developer build Nov 20, 2024
@staniewzki staniewzki marked this pull request as ready for review November 20, 2024 12:25
@staniewzki staniewzki requested a review from a team as a code owner November 20, 2024 12:25
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ldorau ldorau merged commit 0dd3648 into oneapi-src:main Nov 21, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants