Skip to content

Fix some warnings #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix some warnings #914

wants to merge 2 commits into from

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Nov 19, 2024 •
edited
Loading

Description

Fix warnings about:

  • unused parameter
  • wrong format string

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau
Fix format string
7828fb3 
Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau
Fix warnings about unused parameter
7cef07a 
Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau requested a review from a team as a code owner November 19, 2024 13:21
@lukaszstolarczuk
Copy link
Contributor

FYI, this is (at least somehow) covered via #889

@ldorau
Copy link
Contributor Author

ldorau commented Nov 19, 2024

FYI, this is (at least somehow) covered via #889

No, it is already on the main branch :-D

@ldorau ldorau closed this Nov 19, 2024
@ldorau ldorau deleted the Fix_warnings_about_unused_parameter branch November 19, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka Awaiting requested review from bratpiorka

@lukaszstolarczuk lukaszstolarczuk Awaiting requested review from lukaszstolarczuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldorau @lukaszstolarczuk