Remove the disable provider free parameter of jemalloc pool #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
reviewed
Nov 19, 2024
ldorau
changed the title
ldorau
force-pushed
the
Remove_the_disable_provider_free_parameter_of_jemalloc_pool
branch
5 times, most recently
from
272bee1 to
7fb605d
Compare
ldorau
changed the title
ldorau
force-pushed
the
Remove_the_disable_provider_free_parameter_of_jemalloc_pool
branch
2 times, most recently
from
b38cc45 to
2f1aa28
Compare
vinser52
reviewed
Dec 5, 2024
ldorau
force-pushed
the
Remove_the_disable_provider_free_parameter_of_jemalloc_pool
branch
from
2f1aa28 to
3d4093a
Compare
Remove the disable_provider_free parameter of jemalloc pool and all umfJemallocPoolParams*() API. Fixes: oneapi-src#904 Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Remove_the_disable_provider_free_parameter_of_jemalloc_pool
branch
from
3d4093a to
4394ed7
Compare
|
@bratpiorka @vinser52 please re-review. |
|
I like the line add/remove statistics in this PR: +4 −287 :D |
bratpiorka
approved these changes
Dec 6, 2024
vinser52
approved these changes
Dec 6, 2024
|
Since it is an API change, let's include it in |
|
@lukaszstolarczuk @bratpiorka 0.10 ? |
|
Ok, after the discussion with @bratpiorka we agreed not to merge it in 0.10. The reason is that this PR depends on coarse provider changes and would require a lot of related changes to be merged into the 0.10. And we would like to avoid that. jemalloc is not used by oneAPI anyway. |
ldorau
deleted the
Remove_the_disable_provider_free_parameter_of_jemalloc_pool
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the disable_provider_free parameter of jemalloc pool.
Replace it with the Coarse provider in the example.
Fixes: #904
Requires:
Checklist