Add the coarse library #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
reviewed
Nov 25, 2024
ldorau
force-pushed
the
Add_the_coarse_library
branch
from
0747074 to
bf3610b
Compare
It is just a static inner-helper library. There already was an arch discussion about this. |
|
Example of usage: #932 |
5 tasks
|
Code coverage of the coarse library is 92.6%. |
ldorau
force-pushed
the
Add_the_coarse_library
branch
from
bf3610b to
0897b48
Compare
This was referenced Nov 26, 2024
|
@bratpiorka @lplewa please review |
|
overall LGTM. nit: please set year in newly added files to 2024 |
bratpiorka
approved these changes
Nov 28, 2024
ldorau
force-pushed
the
Add_the_coarse_library
branch
from
0897b48 to
814185b
Compare
Done |
ldorau
force-pushed
the
Add_the_coarse_library
branch
from
814185b to
c2fc3db
Compare
|
Rebased |
vinser52
reviewed
Nov 29, 2024
ldorau
force-pushed
the
Add_the_coarse_library
branch
from
c2fc3db to
7dab2ec
Compare
Add the coarse library that will replace the coarse provider. Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_the_coarse_library
branch
from
7dab2ec to
958b690
Compare
vinser52
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the coarse library that will replace the coarse provider.
Example of usage: #932
Code coverage of the coarse library is 92.6%.
Checklist