Skip to content

Added sticky position #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Added sticky position #1692

merged 1 commit into from
Mar 31, 2025

Conversation

Rupak182
Copy link
Contributor

@Rupak182 Rupak182 commented Mar 31, 2025

Description

Added sticky positioning

Related Issues

#1531

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

No Tests added

Screenshots (if applicable)

image


Important

Added sticky to position options in PositionGroup in group.ts.

  • Feature Addition:
    • Added sticky to position options in PositionGroup in group.ts.

This description was created by Ellipsis for b0a89bb. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b0a89bb in 1 minute and 10 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. apps/studio/src/lib/editor/styles/group.ts:42
  • Draft comment:
    Ensure 'sticky' is supported correctly in layout generation and rendering. Consider adding tests for sticky positioning behavior.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
    The comment starts with "Ensure..." which is a red flag per the rules. The comment is speculative about potential issues with sticky positioning. The file only defines available style options - the actual implementation of sticky positioning would be handled elsewhere. This file is just a configuration of what options are available in the UI.
    Maybe sticky positioning does require special handling in the layout engine and this is a valid concern? Maybe there are important edge cases to test?
    While sticky positioning might need special handling, this file only defines UI options. Any implementation concerns should be raised on the files that actually handle the layout rendering, not here.
    Delete the comment. It starts with "Ensure..." which violates the rules, and it raises implementation concerns on a file that only defines UI options.
2. apps/studio/src/lib/editor/styles/group.ts:43
  • Draft comment:
    The sticky option looks valid. Please ensure that sticky positioning is handled properly in the UI (e.g., correct container overflow settings) and consider adding tests or documentation on its behavior.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None

Workflow ID: wflow_0eRNe2RevVkmEMbT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @Rupak182!

@Kitenite Kitenite merged commit aff266d into onlook-dev:main Mar 31, 2025
zongkelong pushed a commit to zongkelong/coolook that referenced this pull request Mar 31, 2025
…slation_zh

* 'main' of https://github.com/onlook-dev/onlook:
  Publish version v0.2.23 (onlook-dev#1694)
  Fix edit panel not fully hidden (onlook-dev#1695)
  Update file watcher and remove elide lines (onlook-dev#1693)
  Add sticky position (onlook-dev#1692)
  Publish version v0.2.22 (onlook-dev#1679)
  added text transforms (onlook-dev#1689)
  Update URL when changing project settings URL (onlook-dev#1690)
  fix: error when setting text color (onlook-dev#1688)
  Revert freestyle source (onlook-dev#1686)
ml-delaurier pushed a commit to ml-delaurier/nolook that referenced this pull request Apr 23, 2025
t1c1 pushed a commit to t1c1/onlookbotcodes that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants