-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update file watcher and remove elide lines #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 0a2b5ab in 44 seconds
More details
- Looked at
51
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. .husky/pre-commit:2
- Draft comment:
Updated pre-commit command now calls 'lint' and 'format' instead of the '-precommit' variants. Ensure that these tasks in package.json produce the correct behavior in the pre-commit hook. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
2. package.json:18
- Draft comment:
Removed '--elide-lines' option from various scripts. Verify that none of the removed flags were necessary for proper build/lint/format behavior, and that the updated commands work as expected for all packages. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
3. .husky/pre-commit:2
- Draft comment:
Updated the lint/format commands to remove the ':precommit' suffix. Ensure this change is intentional and that it aligns with the scripts defined in package.json. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to ensure that the change is intentional and aligns with the scripts inpackage.json
. This is a request for confirmation, which violates the rules. The comment does not provide a specific suggestion or point out a specific issue with the code.
4. package.json:19
- Draft comment:
Removed '--elide-lines 0' flag from the build:cli script. Confirm that the change in verbosity does not hinder debugging or expected output. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to confirm that the change in verbosity does not hinder debugging or expected output. This falls under the rule of not asking the PR author to confirm their intention or ensure the behavior is intended. Therefore, this comment should be removed.
5. package.json:17
- Draft comment:
PR description and referenced issue mention adding framework documentation, yet changes only remove '--elide-lines' flags. Please update the PR description or include the expected documentation changes to fully resolve the issue. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment asks the PR author to update the PR description, which is against the rules. It also suggests that the changes do not align with the PR description, but the focus is on updating the description rather than addressing specific code issues or making suggestions for improvement.
Workflow ID: wflow_TPmu4pxly8kMxlUU
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Generated with ❤️ by ellipsis.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 094f50e in 58 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. apps/studio/electron/main/run/index.ts:195
- Draft comment:
Removing an inline comment is non-functional. Ensure this cleanup is intentional. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
2. apps/studio/electron/main/run/index.ts:195
- Draft comment:
PR title and issue suggest updates to onboarding docs, but diff only removes a comment. Confirm if further documentation changes are needed. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to confirm if further documentation changes are needed, which violates the rule against asking the author to confirm their intention or to ensure the behavior is intended. The comment does not provide a specific code suggestion or request for a test, nor does it point out a specific issue with the code.
3. apps/studio/electron/main/run/index.ts:198
- Draft comment:
The removal of the inline comment is stylistic. Ensure that the clarity of the code is maintained if additional context on selfModified is needed. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
4. apps/studio/electron/main/run/index.ts:198
- Draft comment:
The PR description mentions onboarding docs, but this change only updates the file watcher logic. Please verify that the PR resolves the intended issue. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment asks the PR author to verify that the PR resolves the intended issue, which is against the rules. It also comments on the PR description, which is not allowed.
Workflow ID: wflow_5fltTnOjMRocWN67
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
…slation_zh * 'main' of https://github.com/onlook-dev/onlook: Publish version v0.2.23 (onlook-dev#1694) Fix edit panel not fully hidden (onlook-dev#1695) Update file watcher and remove elide lines (onlook-dev#1693) Add sticky position (onlook-dev#1692) Publish version v0.2.22 (onlook-dev#1679) added text transforms (onlook-dev#1689) Update URL when changing project settings URL (onlook-dev#1690) fix: error when setting text color (onlook-dev#1688) Revert freestyle source (onlook-dev#1686)
* Remove elide lines * Remove atomic write and update file watcher
* Remove elide lines * Remove atomic write and update file watcher
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Important
Updated file watcher logic in
RunManager
and replaced atomic writes with direct writes, along with dependency updates.RunManager
class inindex.ts
, addedselfModified
set to track and ignore self-modified files during file events.writeFileAtomic
withfs.writeFile
inimages.ts
andfiles.ts
for direct file writing..husky/pre-commit
to usebun run lint
andbun run format
.bun.lock
.This description was created by
for 094f50e. It will automatically update as commits are pushed.