chore: error nesting button #1790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 4d71a51 in 31 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. apps/studio/src/routes/editor/LayersPanel/ZoomControls/index.tsx:77
- Draft comment:
Good change replacing the outer button with a div to avoid nesting interactive elements. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. apps/studio/src/routes/editor/LayersPanel/ZoomControls/index.tsx:142
- Draft comment:
Closing tag updated to match the div container. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. apps/studio/src/routes/editor/LayersPanel/ZoomControls/index.tsx:77
- Draft comment:
Good change replacing the outer with ato prevent nested interactive elements. Ensure that the interactive behavior is maintained via the PopoverTrigger (which properly handles accessibility). - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. apps/studio/src/routes/editor/LayersPanel/ZoomControls/index.tsx:36
- Draft comment:
Typographical error: The variable 'lintedScale' on line 36 appears to be a typo. It should likely be renamed to 'clampedScale' to accurately reflect that it holds the clamped value of the new scale. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_VZDVj8a2kc1udeFz
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
ml-delaurier
pushed a commit
to ml-delaurier/nolook
that referenced
this pull request
Apr 23, 2025
zongkelong
pushed a commit
to zongkelong/coolook
that referenced
this pull request
Apr 25, 2025
* 'main' of https://github.com/onlook-dev/onlook: use DomElementStyles (onlook-dev#1810) feat: Added file watcher & auto update modified opened files in Dev Tab (onlook-dev#1802) fix: border thickness hidden when setting border color from color picker (onlook-dev#1805) move overflow input (onlook-dev#1800) Added overflow option in the style panel (onlook-dev#1793) refactor: update images manager (onlook-dev#1784) chore: error nesting button (onlook-dev#1790) refactor: update naming for brand color (onlook-dev#1785) Tys toolbar v4 (onlook-dev#1786)
t1c1
pushed a commit
to t1c1/onlookbotcodes
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Important
Replace
buttonwithdivinZoomControlscomponent to fix button nesting error.buttonwithdivinZoomControlscomponent to fix button nesting error inindex.tsx.This description was created by
for 4d71a51. It will automatically update as commits are pushed.