Skip to content

fix: border thickness hidden when setting border color from color picker #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

Nithishvb
Copy link
Contributor

@Nithishvb Nithishvb commented Apr 23, 2025

Description

This PR fixes the issue where selecting a border color from the color picker causes the border thickness to be hidden. Now, the border thickness remains visible and correctly applied after choosing a color

Related Issues

#1804

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes


Important

Fixes issue in ColorInput where selecting a border color hid the border thickness by adjusting onValueChange callback.

  • Bug Fix:
    • Fixes issue in ColorInput component where selecting a border color from the color picker hid the border thickness.
    • Changes onValueChange callback to use newValue.lightColor instead of colorValue in index.tsx.

This description was created by Ellipsis for 2dae37b. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 2dae37b in 34 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. apps/studio/src/routes/editor/EditPanel/StylesTab/single/ColorInput/index.tsx:132
  • Draft comment:
    Ensure newValue.lightColor is always the intended color for the border update. This change bypasses the computed colorValue, so verify that newValue.lightColor consistently preserves the correct border thickness styling.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify that a specific change is intentional and that it maintains the correct styling. It is not making a specific code suggestion or asking for a test to be written. It seems to be asking for confirmation of intention, which is against the rules.
2. apps/studio/src/routes/editor/EditPanel/StylesTab/single/ColorInput/index.tsx:132
  • Draft comment:
    Using newValue.lightColor instead of the derived colorValue should fix the border display issue. Please ensure that newValue.lightColor is always defined in the expected format to avoid potential inconsistencies in components relying on onValueChange.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 50% <= threshold 50% The comment suggests a specific code change to fix an issue, which is useful. However, it also asks the author to ensure that a value is always defined in a certain format, which violates the rule against asking the author to ensure behavior. The first part of the comment is useful, but the second part is not.
3. apps/studio/src/routes/editor/EditPanel/StylesTab/single/ColorInput/index.tsx:4
  • Draft comment:
    There's a potential typographical error in the import path: 'ColorPalletGroup'. Consider verifying if it should be 'ColorPaletteGroup' to maintain consistent naming.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_feoa10nS7GF4rs3L

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for the fix @Nithishvb!

@Kitenite Kitenite merged commit 5309b94 into onlook-dev:main Apr 24, 2025
zongkelong pushed a commit to zongkelong/coolook that referenced this pull request Apr 25, 2025
* 'main' of https://github.com/onlook-dev/onlook:
  use DomElementStyles (onlook-dev#1810)
  feat: Added file watcher & auto update modified opened files in Dev Tab (onlook-dev#1802)
  fix: border thickness hidden when setting border color from color picker (onlook-dev#1805)
  move overflow input (onlook-dev#1800)
  Added overflow option in the style panel (onlook-dev#1793)
  refactor: update images manager (onlook-dev#1784)
  chore: error nesting button (onlook-dev#1790)
  refactor: update naming for brand color (onlook-dev#1785)
  Tys toolbar v4 (onlook-dev#1786)
t1c1 pushed a commit to t1c1/onlookbotcodes that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants