Skip to content

fix: escape quotes in enum string values #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2020
Merged

fix: escape quotes in enum string values #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b7c92b
test: update to latest github schema. Throws error because enum strin…
gr2m Nov 12, 2020
269cd64
test: escape `'` in enum string values
gr2m Nov 12, 2020
e9ba34b
fix: escape `'` in enum string values
gr2m Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/v3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export default function generateTypesV3(
(node.enum as string[]).map((item) =>
typeof item === "number" || typeof item === "boolean"
? item
: `'${item}'`
: `'${item.replace(/'/g, "\\'")}'`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. In my experience, you should never be too aggressive escaping quotes like this, as you may end up with more things escaped than anticipated.

)
);
}
Expand Down
Loading