Bug 2016228: Use arguments to configure pprof-secret #208

awgreene · 2021-10-21T02:49:43Z

Problem: The secret used to establish a secure connection with
OLM's pprof endpoint is hardcoded to the
openshift-operator-lifecycle-manager namespace. This cannot work
if OLM is not running in that namespace, as is the case on
HyperShift clusters.

Solutions: Allow users to configure the namespace for the pprof
credentials secret.

Problem: The secret used to establish a secure connection with OLM's pprof endpoint is hardcoded to the openshift-operator-lifecycle-manager namespace. This cannot work if OLM is not running in that namespace, as is the case on HyperShift clusters. Solutions: Allow users to configure the namespace for the pprof credentials secret.

openshift-ci · 2021-10-21T02:49:46Z

@awgreene: This pull request references Bugzilla bug 2016228, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2016228: Use arguments to configure pprof-secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-10-21T02:50:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [awgreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

awgreene · 2021-10-21T02:50:25Z

/bugzilla refresh

openshift-ci · 2021-10-21T02:50:32Z

@awgreene: This pull request references Bugzilla bug 2016228, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2021-10-21T02:50:52Z

/bugzilla refresh

openshift-ci · 2021-10-21T02:50:56Z

@awgreene: This pull request references Bugzilla bug 2016228, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2021-10-21T13:29:00Z

/retest

timflannagan · 2021-10-21T13:29:14Z

/lgtm

openshift-bot · 2021-10-21T16:22:09Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T17:36:09Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T18:00:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

awgreene · 2021-10-21T19:32:39Z

/bugzilla refresh

openshift-ci · 2021-10-21T19:32:44Z

@awgreene: This pull request references Bugzilla bug 2016228, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-21T20:59:08Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T21:51:10Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-10-21T23:19:44Z

@awgreene: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#208

Bugzilla bug 2016228 has been moved to the MODIFIED state.

In response to this:

Bug 2016228: Use arguments to configure pprof-secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2021-10-25T01:15:34Z

/label qe-approved

awgreene · 2021-10-26T14:00:39Z

/cherry-pick release-4.9

openshift-cherrypick-robot · 2021-10-26T14:01:36Z

@awgreene: new pull request created: #212

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

openshift-ci bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Oct 21, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 21, 2021

openshift-ci bot requested review from anik120 and exdx October 21, 2021 02:50

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 21, 2021

openshift-ci bot requested a review from jianzhangbjz October 21, 2021 02:50

openshift-ci bot assigned timflannagan Oct 21, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2021

awgreene mentioned this pull request Oct 21, 2021

Bug 2015793: Run OLM's collect profiles job on the management cluster openshift/hypershift#583

Merged

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Oct 21, 2021

openshift-merge-robot merged commit 6d684d4 into openshift:master Oct 21, 2021

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 25, 2021

openshift-cherrypick-robot mentioned this pull request Oct 26, 2021

[release-4.9] Bug 2017434: Use arguments to configure pprof-secret #212

Merged

awgreene pushed a commit to awgreene/operator-framework-olm that referenced this pull request Feb 2, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

5f414d5

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

awgreene pushed a commit to awgreene/operator-framework-olm that referenced this pull request Feb 22, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

5cdaa49

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 1, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

07adadf

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

64a3e0d

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

7f3db94

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

52deb1f

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

53e0cf9

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

41846d1

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

1fea744

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

5fccf91

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

14d832e

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

0699e7a

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

e583eef

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 8, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

8cfb223

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 9, 2022

deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 (…

718aa3d

…openshift#208) Upstream-repository: api Upstream-commit: bfa93d1e8c6e0bcc792a85cab5fb8f3086727834

Bug 2016228: Use arguments to configure pprof-secret #208

Bug 2016228: Use arguments to configure pprof-secret #208

Uh oh!

Conversation

awgreene commented Oct 21, 2021

Uh oh!

openshift-ci bot commented Oct 21, 2021

Uh oh!

openshift-ci bot commented Oct 21, 2021

Uh oh!

awgreene commented Oct 21, 2021

Uh oh!

openshift-ci bot commented Oct 21, 2021

Uh oh!

awgreene commented Oct 21, 2021

Uh oh!

openshift-ci bot commented Oct 21, 2021

Uh oh!

awgreene commented Oct 21, 2021

Uh oh!

timflannagan commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

awgreene commented Oct 21, 2021

Uh oh!

openshift-ci bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-ci bot commented Oct 21, 2021

Uh oh!

jianzhangbjz commented Oct 25, 2021

Uh oh!

awgreene commented Oct 26, 2021

Uh oh!

openshift-cherrypick-robot commented Oct 26, 2021

Uh oh!

Uh oh!