Skip to content

[release-4.9] Bug 2017434: Use arguments to configure pprof-secret #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2021
Merged

[release-4.9] Bug 2017434: Use arguments to configure pprof-secret #212

merged 1 commit into from
Nov 1, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #208

/assign awgreene

@awgreene
Use arguments to configure pprof-secret
fe8ae02 
Problem: The secret used to establish a secure connection with
OLM's pprof endpoint is hardcoded to the
openshift-operator-lifecycle-manager namespace. This cannot work
if OLM is not running in that namespace, as is the case on
HyperShift clusters.

Solutions: Allow users to configure the namespace for the pprof
credentials secret.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 26, 2021
Merged
@openshift-ci openshift-ci bot requested review from benluddy and kevinrizza October 26, 2021 14:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2021

@openshift-cherrypick-robot: Bugzilla bug 2016228 has been cloned as Bugzilla bug 2017434. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2017434: Use arguments to configure pprof-secret

In response to this:

[release-4.9] Bug 2016228: Use arguments to configure pprof-secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2016228: Use arguments to configure pprof-secret [release-4.9] Bug 2017434: Use arguments to configure pprof-secret Oct 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2021

@openshift-cherrypick-robot: An error was encountered querying GitHub for users with public email ([email protected]) for bug 2017434 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Bug 2017434: Use arguments to configure pprof-secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kevinrizza
Copy link
Member

/label backport-risk-assessed
/lgtm

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 27, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@awgreene
Copy link
Contributor

/retest

ankitathomas
ankitathomas approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tylerslaton
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, openshift-cherrypick-robot, tylerslaton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2021
@njhale
Copy link
Contributor

njhale commented Oct 29, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2021

@njhale: This pull request references Bugzilla bug 2017434, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2016228 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2016228 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 29, 2021
@openshift-ci openshift-ci bot requested a review from jianzhangbjz October 29, 2021 18:11
@stleerh stleerh added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6a8cbc2 into openshift:release-4.9 Nov 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2017434 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2017434: Use arguments to configure pprof-secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene pushed a commit to awgreene/operator-framework-olm that referenced this pull request Feb 2, 2022
@varshaprasad96 @awgreene
chore: Bump k8s dependencies to 1.23 (openshift#212)
34823a3 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repositroy: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
awgreene pushed a commit to awgreene/operator-framework-olm that referenced this pull request Feb 22, 2022
@varshaprasad96 @awgreene
chore: Bump k8s dependencies to 1.23 (openshift#212)
614aef3 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 1, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
330c9ca 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
Upstream-commit: api
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
acc145d 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
Upstream-commit: api
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
25994f9 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
Upstream-commit: api
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
0e7bf4f 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
Upstream-commit: api
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
9d71208 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
e7110ca 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
2684224 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
0845fa1 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
7397f64 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
bab604e 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
005a20d 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 8, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
908c892 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 9, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
a014b98 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 10, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
e685f14 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 10, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
a148813 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 12, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
f29d2e1 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request May 30, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
2fd8cfb 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request May 30, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
76a3cac 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
Signed-off-by: perdasilva <[email protected]>
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request May 30, 2022
@varshaprasad96 @perdasilva
chore: Bump k8s dependencies to 1.23 (openshift#212)
8eb128f 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
Signed-off-by: perdasilva <[email protected]>
ankitathomas pushed a commit to ankitathomas/operator-framework-olm that referenced this pull request Jul 31, 2023
@varshaprasad96 @ankitathomas
chore: Bump k8s dependencies to 1.23 (openshift#212)
c5b0fcd 
Some notable bumps in versions:
1. Controller-runtime to 0.11.0
2. Controller-tools to 0.8.0
3. K8s modules to 1.23+
4. Go to 1.17

Upstream-repository: api
Upstream-commit: 12a70c0e4176b7ec7922e2ce3a6b3c94b4f3062d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas ankitathomas approved these changes

@benluddy benluddy Awaiting requested review from benluddy

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@kevinrizza kevinrizza

@awgreene awgreene

@ankitathomas ankitathomas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@openshift-cherrypick-robot @kevinrizza @awgreene @tylerslaton @njhale @ankitathomas @openshift-merge-robot @stleerh