[release-4.8] Bug 2073963: Fix a bug in deletion of webhook service for replacement #281

openshift-cherrypick-robot · 2022-04-11T08:54:38Z

This is an automated cherry-pick of #272

/assign perdasilva

The condition that checks for an error with the webhook service deletion is based on the wrong variable, and the return statement is never reached, which leads to a continuous error when OLM tries to replace the webhook service on certain conditions Signed-off-by: orenc1 <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: e9aef37a1f293bbbf833206f2037a2f36ffe2673

openshift-ci · 2022-04-11T08:54:53Z

@openshift-cherrypick-robot: Bugzilla bug 2070131 has been cloned as Bugzilla bug 2073963. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 2073963: Fix a bug in deletion of webhook service for replacement

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-11T08:55:06Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2073963, which is invalid:

expected dependent Bugzilla bug 2070131 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
expected dependent Bugzilla bug 2070131 to target a release in 4.9.0, 4.9.z, but it targets "4.10.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-11T09:49:08Z

/bugzilla refresh

openshift-ci · 2022-04-11T09:49:30Z

@perdasilva: This pull request references Bugzilla bug 2073963, which is invalid:

expected dependent Bugzilla bug 2070131 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
expected dependent Bugzilla bug 2073964 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
expected dependent Bugzilla bug 2073966 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
expected dependent Bugzilla bug 2073967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
expected dependent Bugzilla bug 2070131 to target a release in 4.9.0, 4.9.z, but it targets "4.10.z" instead
expected dependent Bugzilla bug 2073964 to target a release in 4.9.0, 4.9.z, but it targets "4.7.z" instead
expected dependent Bugzilla bug 2073966 to target a release in 4.9.0, 4.9.z, but it targets "4.6.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-11T09:51:45Z

/bugzilla refresh

openshift-ci · 2022-04-11T09:51:55Z

@perdasilva: This pull request references Bugzilla bug 2073963, which is invalid:

expected dependent Bugzilla bug 2073964 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
expected dependent Bugzilla bug 2073966 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
expected dependent Bugzilla bug 2073967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
expected dependent Bugzilla bug 2070131 to target a release in 4.9.0, 4.9.z, but it targets "4.10.z" instead
expected dependent Bugzilla bug 2073964 to target a release in 4.9.0, 4.9.z, but it targets "4.7.z" instead
expected dependent Bugzilla bug 2073966 to target a release in 4.9.0, 4.9.z, but it targets "4.6.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-11T11:49:24Z

/test e2e-upgrade

perdasilva · 2022-04-11T14:21:07Z

/test e2e-upgrade

perdasilva · 2022-04-11T16:59:27Z

/test e2e-upgrade

openshift-ci · 2022-04-11T19:10:22Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

perdasilva · 2022-04-12T07:17:18Z

/bugzilla refresh

openshift-ci · 2022-04-12T07:17:25Z

@perdasilva: This pull request references Bugzilla bug 2073963, which is invalid:

expected dependent Bugzilla bug 2073967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
expected dependent Bugzilla bug 2073964 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (WONTFIX) instead
expected dependent Bugzilla bug 2073966 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (WONTFIX) instead
expected dependent Bugzilla bug 2070131 to target a release in 4.9.0, 4.9.z, but it targets "4.10.z" instead
expected dependent Bugzilla bug 2073964 to target a release in 4.9.0, 4.9.z, but it targets "4.7.z" instead
expected dependent Bugzilla bug 2073966 to target a release in 4.9.0, 4.9.z, but it targets "4.6.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-12T07:20:27Z

/bugzilla refresh

openshift-ci · 2022-04-12T07:20:32Z

@perdasilva: This pull request references Bugzilla bug 2073963, which is invalid:

expected dependent Bugzilla bug 2073967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
expected dependent Bugzilla bug 2070131 to target a release in 4.9.0, 4.9.z, but it targets "4.10.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-12T07:24:30Z

/bugzilla refresh

openshift-ci · 2022-04-12T07:24:35Z

@perdasilva: This pull request references Bugzilla bug 2073963, which is invalid:

expected dependent Bugzilla bug 2073967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-12T14:25:40Z

/bugzilla refresh

openshift-ci · 2022-04-12T14:27:05Z

@perdasilva: This pull request references Bugzilla bug 2073963, which is invalid:

expected dependent Bugzilla bug 2073967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-12T14:37:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-04-13T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-13T01:01:12Z

@openshift-bot: This pull request references Bugzilla bug 2073963, which is invalid:

expected dependent Bugzilla bug 2073967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-13T08:17:54Z

/bugzilla refresh

openshift-ci · 2022-04-13T08:18:09Z

@perdasilva: This pull request references Bugzilla bug 2073963, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2073967 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2073967 targets the "4.9.z" release, which is one of the valid target releases: 4.9.0, 4.9.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-13T08:18:31Z

/label backport-risk-assessed

jianzhangbjz · 2022-04-13T14:18:07Z

/label cherry-pick-approved

openshift-ci · 2022-04-13T14:19:30Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#281

Bugzilla bug 2073963 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot assigned perdasilva Apr 11, 2022

openshift-cherrypick-robot mentioned this pull request Apr 11, 2022

Bug 2070131: Fix a bug in deletion of webhook service for replacement #272

Merged

openshift-ci bot changed the title ~~[release-4.8] Bug 2070131: Fix a bug in deletion of webhook service for replacement~~ [release-4.8] Bug 2073963: Fix a bug in deletion of webhook service for replacement Apr 11, 2022

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 11, 2022

openshift-ci bot requested review from ankitathomas and timflannagan April 11, 2022 08:55

timflannagan approved these changes Apr 12, 2022

View reviewed changes

openshift-ci bot assigned timflannagan Apr 12, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 13, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 13, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 13, 2022

openshift-merge-robot merged commit 0f188bc into openshift:release-4.8 Apr 13, 2022

[release-4.8] Bug 2073963: Fix a bug in deletion of webhook service for replacement #281

[release-4.8] Bug 2073963: Fix a bug in deletion of webhook service for replacement #281

Uh oh!

Conversation

openshift-cherrypick-robot commented Apr 11, 2022

Uh oh!

openshift-ci bot commented Apr 11, 2022

Uh oh!

openshift-ci bot commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

openshift-ci bot commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

openshift-ci bot commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

openshift-ci bot commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 12, 2022

Uh oh!

openshift-ci bot commented Apr 12, 2022

Uh oh!

perdasilva commented Apr 12, 2022

Uh oh!

openshift-ci bot commented Apr 12, 2022

Uh oh!

perdasilva commented Apr 12, 2022

Uh oh!

openshift-ci bot commented Apr 12, 2022

Uh oh!

perdasilva commented Apr 12, 2022

Uh oh!

openshift-ci bot commented Apr 12, 2022

Uh oh!

openshift-ci bot commented Apr 12, 2022

Uh oh!

openshift-bot commented Apr 13, 2022

Uh oh!

openshift-ci bot commented Apr 13, 2022

Uh oh!

perdasilva commented Apr 13, 2022

Uh oh!

openshift-ci bot commented Apr 13, 2022

Uh oh!

perdasilva commented Apr 13, 2022

Uh oh!

jianzhangbjz commented Apr 13, 2022

Uh oh!

openshift-ci bot commented Apr 13, 2022

Uh oh!

Uh oh!