Bug 2070131: Fix a bug in deletion of webhook service for replacement #272

perdasilva · 2022-03-30T13:27:16Z

The condition that checks for an error with the webhook service deletion is based on the wrong variable, and the return statement is never reached, which leads to a continuous error when OLM tries to replace the webhook service on certain conditions

Signed-off-by: orenc1 [email protected]
Upstream-repository: operator-lifecycle-manager
Upstream-commit: e9aef37a1f293bbbf833206f2037a2f36ffe2673

perdasilva · 2022-03-30T13:31:43Z

/cherry-pick release-4.9

openshift-cherrypick-robot · 2022-03-30T13:32:48Z

@perdasilva: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-03-30T13:36:55Z

/cherry-pick release-4.8

openshift-cherrypick-robot · 2022-03-30T13:37:31Z

@perdasilva: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-03-30T13:37:41Z

/cherry-pick release-4.7

perdasilva · 2022-03-30T13:38:17Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2022-03-30T13:38:46Z

@perdasilva: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-03-30T13:39:22Z

@perdasilva: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-03-30T16:03:29Z

/retest

perdasilva · 2022-03-30T17:05:00Z

/retest

perdasilva · 2022-03-31T07:44:54Z

/retest

perdasilva · 2022-03-31T14:49:44Z

/retest

openshift-ci · 2022-04-01T06:25:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

perdasilva · 2022-04-01T06:46:00Z

/retest-required

openshift-ci · 2022-04-01T07:45:29Z

@perdasilva: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix a bug in deletion of webhook service for replacement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-01T07:45:53Z

@perdasilva: This pull request references Bugzilla bug 2070131, which is invalid:

expected dependent Bugzilla bug 2048441 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
expected dependent Bugzilla bug 2048441 to target a release in 4.11.0, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2070131: Fix a bug in deletion of webhook service for replacement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-01T07:55:18Z

/bugzilla refresh

openshift-ci · 2022-04-01T07:55:22Z

@perdasilva: This pull request references Bugzilla bug 2070131, which is invalid:

expected dependent Bugzilla bug 2048441 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-04T18:00:04Z

/test e2e-aws-olm

openshift-bot · 2022-04-04T20:46:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-05T00:11:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-04-05T02:17:33Z

@perdasilva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-olm	`2b1f95a`	link	true	`/test e2e-gcp-olm`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-04-05T02:52:04Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

perdasilva · 2022-04-05T07:06:25Z

Valeu @bandrade!!!

perdasilva · 2022-04-05T07:55:05Z

/label cherry-pick-approved

openshift-ci · 2022-04-05T07:55:06Z

@perdasilva: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-05T13:20:03Z

/hold wait until next week - 4.10 branch is picky atm

bandrade · 2022-04-05T14:25:39Z

/cherry-pick-approved

timflannagan · 2022-04-05T14:35:17Z

@bandrade Interesting - it looks like you need to prefix that with /label cherry-pick-approved?

bandrade · 2022-04-05T16:30:42Z

/label cherry-pick-approved

perdasilva · 2022-04-11T08:51:25Z

/hold cancel

openshift-ci · 2022-04-11T08:53:55Z

@perdasilva: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#272

Bugzilla bug 2070131 has been moved to the MODIFIED state.

In response to this:

Bug 2070131: Fix a bug in deletion of webhook service for replacement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-04-11T08:54:40Z

@perdasilva: new pull request created: #281

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-04-11T08:55:22Z

@perdasilva: new pull request created: #282

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-04-11T08:56:04Z

@perdasilva: new pull request created: #283

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-04-11T08:56:43Z

@perdasilva: new pull request created: #284

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Jose R. Gonzalez <[email protected]> Upstream-repository: api Upstream-commit: e6998ff1feb3c5efac1458daa5006350c7e0eccd

perdasilva changed the title ~~Bug #2070131 Fix a bug in deletion of webhook service for replacement~~ Bug 2070131: Fix a bug in deletion of webhook service for replacement Mar 30, 2022

perdasilva changed the base branch from master to release-4.10 March 30, 2022 13:28

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 30, 2022

perdasilva force-pushed the bug_2070131 branch from 2b1f95a to 55503f8 Compare April 1, 2022 06:24

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2022

perdasilva changed the title ~~Bug 2070131: Fix a bug in deletion of webhook service for replacement~~ Fix a bug in deletion of webhook service for replacement Apr 1, 2022

openshift-ci bot removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 1, 2022

perdasilva changed the title ~~Fix a bug in deletion of webhook service for replacement~~ Bug 2070131: Fix a bug in deletion of webhook service for replacement Apr 1, 2022

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 1, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 5, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2022

openshift-merge-robot merged commit b576eef into openshift:release-4.10 Apr 11, 2022

openshift-cherrypick-robot mentioned this pull request Apr 11, 2022

[release-4.8] Bug 2073963: Fix a bug in deletion of webhook service for replacement #281

Merged

openshift-cherrypick-robot mentioned this pull request Apr 11, 2022

[release-4.7] Bug 2073964: Fix a bug in deletion of webhook service for replacement #282

Closed

openshift-cherrypick-robot mentioned this pull request Apr 11, 2022

[release-4.6] Bug 2073966: Fix a bug in deletion of webhook service for replacement #283

Closed

openshift-cherrypick-robot mentioned this pull request Apr 11, 2022

[release-4.9] Bug 2073967: Fix a bug in deletion of webhook service for replacement #284

Merged

openshift-bot mentioned this pull request Jan 11, 2024

NO-ISSUE: Synchronize From Upstream Repositories #656

Closed

tmshort mentioned this pull request Jan 16, 2024

NO-ISSUE: Synchronize From Upstream Repositories #659

Merged

Bug 2070131: Fix a bug in deletion of webhook service for replacement #272

Bug 2070131: Fix a bug in deletion of webhook service for replacement #272

Uh oh!

Conversation

perdasilva commented Mar 30, 2022

Uh oh!

perdasilva commented Mar 30, 2022

Uh oh!

openshift-cherrypick-robot commented Mar 30, 2022

Uh oh!

perdasilva commented Mar 30, 2022

Uh oh!

openshift-cherrypick-robot commented Mar 30, 2022

Uh oh!

perdasilva commented Mar 30, 2022

Uh oh!

perdasilva commented Mar 30, 2022

Uh oh!

openshift-cherrypick-robot commented Mar 30, 2022

Uh oh!

openshift-cherrypick-robot commented Mar 30, 2022

Uh oh!

perdasilva commented Mar 30, 2022

Uh oh!

perdasilva commented Mar 30, 2022

Uh oh!

perdasilva commented Mar 31, 2022

Uh oh!

perdasilva commented Mar 31, 2022

Uh oh!

openshift-ci bot commented Apr 1, 2022

Uh oh!

perdasilva commented Apr 1, 2022

Uh oh!

openshift-ci bot commented Apr 1, 2022

Uh oh!

openshift-ci bot commented Apr 1, 2022

Uh oh!

perdasilva commented Apr 1, 2022

Uh oh!

openshift-ci bot commented Apr 1, 2022

Uh oh!

perdasilva commented Apr 4, 2022

Uh oh!

openshift-bot commented Apr 4, 2022

Uh oh!

openshift-bot commented Apr 5, 2022

Uh oh!

openshift-ci bot commented Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Apr 5, 2022

Uh oh!

perdasilva commented Apr 5, 2022

Uh oh!

perdasilva commented Apr 5, 2022

Uh oh!

openshift-ci bot commented Apr 5, 2022

Uh oh!

perdasilva commented Apr 5, 2022

Uh oh!

bandrade commented Apr 5, 2022

Uh oh!

timflannagan commented Apr 5, 2022

Uh oh!

bandrade commented Apr 5, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

openshift-ci bot commented Apr 11, 2022

Uh oh!

openshift-cherrypick-robot commented Apr 11, 2022

Uh oh!

openshift-cherrypick-robot commented Apr 11, 2022

Uh oh!

openshift-cherrypick-robot commented Apr 11, 2022

Uh oh!

openshift-cherrypick-robot commented Apr 11, 2022

Uh oh!

Uh oh!

openshift-ci bot commented Apr 5, 2022 •

edited

Loading