[release-4.9] Bug 2073967: Fix a bug in deletion of webhook service for replacement #284

openshift-cherrypick-robot · 2022-04-11T08:56:42Z

This is an automated cherry-pick of #272

/assign perdasilva

The condition that checks for an error with the webhook service deletion is based on the wrong variable, and the return statement is never reached, which leads to a continuous error when OLM tries to replace the webhook service on certain conditions Signed-off-by: orenc1 <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: e9aef37a1f293bbbf833206f2037a2f36ffe2673

openshift-ci · 2022-04-11T08:57:01Z

@openshift-cherrypick-robot: Bugzilla bug 2070131 has been cloned as Bugzilla bug 2073967. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2073967: Fix a bug in deletion of webhook service for replacement

In response to this:

[release-4.9] Bug 2070131: Fix a bug in deletion of webhook service for replacement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-11T08:57:09Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2073967, which is invalid:

expected dependent Bugzilla bug 2070131 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2073967: Fix a bug in deletion of webhook service for replacement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-11T09:48:51Z

/bugzilla refresh

openshift-ci · 2022-04-11T09:48:55Z

@perdasilva: This pull request references Bugzilla bug 2073967, which is invalid:

expected dependent Bugzilla bug 2070131 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-11T09:50:40Z

/bugzilla refresh

openshift-ci · 2022-04-11T09:50:51Z

@perdasilva: This pull request references Bugzilla bug 2073967, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2070131 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2070131 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-11T09:52:32Z

@bandrade could you please take a look?

perdasilva · 2022-04-11T09:52:48Z

/label backport-risk-assessed

jianzhangbjz · 2022-04-11T09:56:33Z

/label cherry-pick-approved

perdasilva · 2022-04-11T11:47:03Z

/test e2e-upgrade

perdasilva · 2022-04-11T14:21:31Z

/test e2e-upgrade

perdasilva · 2022-04-11T16:59:18Z

/test e2e-upgrade

perdasilva · 2022-04-11T17:10:17Z

/test e2e-upgrade

timflannagan · 2022-04-11T18:53:02Z

/retest-required

openshift-ci · 2022-04-11T18:54:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

timflannagan · 2022-04-11T21:00:08Z

/retest-required

openshift-bot · 2022-04-12T03:43:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-12T03:56:09Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-04-12T04:51:43Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-04-12T04:54:19Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#284

Bugzilla bug 2073967 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2073967: Fix a bug in deletion of webhook service for replacement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Adam D. Cornett <[email protected]> Upstream-repository: api Upstream-commit: aa3e49803e7bc8fa723077988abad399159abb22

openshift-cherrypick-robot mentioned this pull request Apr 11, 2022

Bug 2070131: Fix a bug in deletion of webhook service for replacement #272

Merged

openshift-ci bot assigned perdasilva Apr 11, 2022

openshift-ci bot changed the title ~~[release-4.9] Bug 2070131: Fix a bug in deletion of webhook service for replacement~~ [release-4.9] Bug 2073967: Fix a bug in deletion of webhook service for replacement Apr 11, 2022

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 11, 2022

openshift-ci bot requested review from benluddy and kevinrizza April 11, 2022 08:57

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 11, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 11, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 11, 2022

timflannagan approved these changes Apr 11, 2022

View reviewed changes

openshift-ci bot assigned timflannagan Apr 11, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2022

openshift-merge-robot merged commit a336955 into openshift:release-4.9 Apr 12, 2022

tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 11, 2023

updating dependencies (openshift#284)

3215287

Signed-off-by: Adam D. Cornett <[email protected]> Upstream-repository: api Upstream-commit: aa3e49803e7bc8fa723077988abad399159abb22

tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 17, 2023

updating dependencies (openshift#284)

389dfe4

Signed-off-by: Adam D. Cornett <[email protected]> Upstream-repository: api Upstream-commit: aa3e49803e7bc8fa723077988abad399159abb22

tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 20, 2023

updating dependencies (openshift#284)

948ba2b

Signed-off-by: Adam D. Cornett <[email protected]> Upstream-repository: api Upstream-commit: aa3e49803e7bc8fa723077988abad399159abb22

[release-4.9] Bug 2073967: Fix a bug in deletion of webhook service for replacement #284

[release-4.9] Bug 2073967: Fix a bug in deletion of webhook service for replacement #284

Uh oh!

Conversation

openshift-cherrypick-robot commented Apr 11, 2022

Uh oh!

openshift-ci bot commented Apr 11, 2022

Uh oh!

openshift-ci bot commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

openshift-ci bot commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

openshift-ci bot commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

jianzhangbjz commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

perdasilva commented Apr 11, 2022

Uh oh!

timflannagan commented Apr 11, 2022

Uh oh!

openshift-ci bot commented Apr 11, 2022

Uh oh!

timflannagan commented Apr 11, 2022

Uh oh!

openshift-bot commented Apr 12, 2022

Uh oh!

openshift-bot commented Apr 12, 2022

Uh oh!

openshift-ci bot commented Apr 12, 2022

Uh oh!

openshift-ci bot commented Apr 12, 2022

Uh oh!

Uh oh!