Skip to content

[release-4.6] Bug 2073966: Fix a bug in deletion of webhook service for replacement #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[release-4.6] Bug 2073966: Fix a bug in deletion of webhook service for replacement #283

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #272

/assign perdasilva

@orenc1
Fix a bug in deletion of webhook service for replacement (#2606)
03ead81 
The condition that checks for an error with the webhook service deletion is based on the wrong variable, and the return statement is never reached, which leads to a continuous error when OLM tries to replace the webhook service on certain conditions

Signed-off-by: orenc1 <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: e9aef37a1f293bbbf833206f2037a2f36ffe2673
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 11, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

@openshift-cherrypick-robot: Bugzilla bug 2070131 has been cloned as Bugzilla bug 2073966. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 2073966: Fix a bug in deletion of webhook service for replacement

In response to this:

[release-4.6] Bug 2070131: Fix a bug in deletion of webhook service for replacement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.6] Bug 2070131: Fix a bug in deletion of webhook service for replacement [release-4.6] Bug 2073966: Fix a bug in deletion of webhook service for replacement Apr 11, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2073966, which is invalid:

  • expected dependent Bugzilla bug 2070131 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
  • expected dependent Bugzilla bug 2073967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
  • expected dependent Bugzilla bug 2070131 to target a release in 4.7.0, 4.7.z, but it targets "4.10.z" instead
  • expected dependent Bugzilla bug 2073967 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 2073966: Fix a bug in deletion of webhook service for replacement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign exdx after the PR has been reviewed.
You can assign the PR to them by writing /assign @exdx in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva
Copy link
Contributor

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

@perdasilva: This pull request references Bugzilla bug 2073966, which is invalid:

  • expected dependent Bugzilla bug 2070131 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 2073967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
  • expected dependent Bugzilla bug 2070131 to target a release in 4.7.0, 4.7.z, but it targets "4.10.z" instead
  • expected dependent Bugzilla bug 2073967 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

@perdasilva: This pull request references Bugzilla bug 2073966, which is invalid:

  • expected dependent Bugzilla bug 2073967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 2070131 to target a release in 4.7.0, 4.7.z, but it targets "4.10.z" instead
  • expected dependent Bugzilla bug 2073967 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor

/close

@openshift-ci openshift-ci bot closed this Apr 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

@perdasilva: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 11, 2023
@m1kola @tmshort
Restores openapi-gen tag for APIResourceReference (openshift#283)
917ca29 
Signed-off-by: Mikalai Radchuk <[email protected]>
Upstream-repository: api
Upstream-commit: 047ab0bc86ca87529fa395c43c1f33eb7345d45f
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 17, 2023
@m1kola @tmshort
Restores openapi-gen tag for APIResourceReference (openshift#283)
48a335a 
Signed-off-by: Mikalai Radchuk <[email protected]>
Upstream-repository: api
Upstream-commit: 047ab0bc86ca87529fa395c43c1f33eb7345d45f
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 20, 2023
@m1kola @tmshort
Restores openapi-gen tag for APIResourceReference (openshift#283)
2a6860a 
Signed-off-by: Mikalai Radchuk <[email protected]>
Upstream-repository: api
Upstream-commit: 047ab0bc86ca87529fa395c43c1f33eb7345d45f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@timflannagan timflannagan Awaiting requested review from timflannagan

Assignees

@perdasilva perdasilva

Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @perdasilva @orenc1