Bug 2093288: fix(grpc): Add startupProbe to check for grpc health readiness (#2791) #314

dinhxuanvu · 2022-06-03T12:28:22Z

Currently, liveness and readiness probes may fail due to grpc is not
ready. Adding a startupProbe will ensure grpc is ready before
liveness and readiness probes are triggered.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 8987522f97ea3726b42ce6fe23ce5aa75efa83ba

Signed-off-by: Vu Dinh [email protected]

openshift-ci · 2022-06-03T12:53:31Z

@dinhxuanvu: This pull request references Bugzilla bug 2093288, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2093288: fix(grpc): Add startupProbe to check for grpc health readiness (#2791)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu · 2022-06-03T12:57:10Z

/bugzilla refresh

openshift-ci · 2022-06-03T12:57:17Z

@dinhxuanvu: This pull request references Bugzilla bug 2093288, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-06-03T14:01:23Z

@grokspawn: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-06-03T16:01:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dinhxuanvu,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dinhxuanvu · 2022-06-03T16:17:36Z

/test e2e-gcp-olm

openshift-ci-robot · 2022-06-03T19:43:40Z

/retest-required

Remaining retests: 2 against base HEAD 7f8ad59 and 8 for PR HEAD 79a4998 in total

openshift-ci-robot · 2022-06-03T22:43:32Z

/retest-required

Remaining retests: 1 against base HEAD 7f8ad59 and 7 for PR HEAD 79a4998 in total

openshift-ci-robot · 2022-06-04T01:43:29Z

/retest-required

Remaining retests: 0 against base HEAD 7f8ad59 and 6 for PR HEAD 79a4998 in total

grokspawn · 2022-06-04T20:04:00Z

/retest-required

jianzhangbjz · 2022-06-06T03:42:13Z

/bugzilla refresh

openshift-ci · 2022-06-06T03:42:17Z

@jianzhangbjz: This pull request references Bugzilla bug 2093288, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2022-06-06T03:42:32Z

/test e2e-gcp-olm

Xia-Zhao-rh · 2022-06-06T06:44:23Z

/test e2e-gcp-olm

Xia-Zhao-rh · 2022-06-06T06:55:45Z

/label qe-approved

kevinrizza · 2022-06-06T19:48:15Z

/test e2e-gcp-olm

jianzhangbjz · 2022-06-15T10:07:37Z

/test e2e-gcp-olm

dinhxuanvu · 2022-06-15T14:24:03Z

This PR won't pass CI until another fix (that's still pending in upstream) gets merged first. Hold for now.
/hold

dinhxuanvu · 2022-06-17T20:51:17Z

Will rebase and merge this PR after #316 merged.

Currently, liveness and readiness probes may fail due to grpc is not ready. Adding a startupProbe will ensure grpc is ready before liveness and readiness probes are triggered. Upstream-repository: operator-lifecycle-manager Upstream-commit: 8987522f97ea3726b42ce6fe23ce5aa75efa83ba Signed-off-by: Vu Dinh <[email protected]>

perdasilva · 2022-06-21T06:24:17Z

/hold cancel

perdasilva · 2022-06-21T06:24:35Z

/lgtm

openshift-ci-robot · 2022-06-21T07:55:15Z

/retest-required

Remaining retests: 2 against base HEAD a8dabfa and 8 for PR HEAD 5e20dc6 in total

perdasilva · 2022-06-21T09:11:33Z

/retest-required

openshift-ci · 2022-06-21T11:34:07Z

@dinhxuanvu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-06-21T11:37:50Z

@dinhxuanvu: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#314

Bugzilla bug 2093288 has been moved to the MODIFIED state.

In response to this:

Bug 2093288: fix(grpc): Add startupProbe to check for grpc health readiness (#2791)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu · 2022-08-01T19:36:11Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-08-01T19:36:57Z

@dinhxuanvu: #314 failed to apply on top of branch "release-4.10":

Applying: fix(grpc): Add startupProbe to check for grpc health readiness (#2791)
Using index info to reconstruct a base tree...
M	staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/reconciler.go
M	vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/reconciler/reconciler.go
Falling back to patching base and 3-way merge...
Auto-merging vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/reconciler/reconciler.go
CONFLICT (content): Merge conflict in vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/reconciler/reconciler.go
Auto-merging staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/reconciler.go
CONFLICT (content): Merge conflict in staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/reconciler.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix(grpc): Add startupProbe to check for grpc health readiness (#2791)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Jordan Keister <[email protected]> Upstream-repository: api Upstream-commit: 37fd5ddbe67913f3eaefb12dffa65b05437d64d5

openshift-ci bot requested review from hasbro17 and perdasilva June 3, 2022 12:28

openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 3, 2022

dinhxuanvu force-pushed the startup-probe branch from 283e56a to be76132 Compare June 3, 2022 12:31

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2022

dinhxuanvu force-pushed the startup-probe branch from eeaf131 to 865a838 Compare June 3, 2022 12:41

dinhxuanvu changed the title ~~fix(grpc): Add startupProbe to check for grpc health readiness (#2791)~~ Bug 2093288: fix(grpc): Add startupProbe to check for grpc health readiness (#2791) Jun 3, 2022

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 3, 2022

dinhxuanvu force-pushed the startup-probe branch from 865a838 to 79a4998 Compare June 3, 2022 12:54

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 3, 2022

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 3, 2022

openshift-ci bot requested a review from jianzhangbjz June 3, 2022 12:57

timflannagan approved these changes Jun 3, 2022

View reviewed changes

openshift-ci bot assigned timflannagan Jun 3, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 6, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2022

perdasilva force-pushed the startup-probe branch from 79a4998 to 5e20dc6 Compare June 21, 2022 05:59

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2022

openshift-ci bot assigned perdasilva Jun 21, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022

openshift-ci bot merged commit 6c5e382 into openshift:master Jun 21, 2022

openshift-bot mentioned this pull request Feb 28, 2024

NO-ISSUE: Synchronize From Upstream Repositories #702

Merged

perdasilva mentioned this pull request May 6, 2024

NO-ISSUE: Synchronize From Upstream Repositories #742

Closed

Bug 2093288: fix(grpc): Add startupProbe to check for grpc health readiness (#2791) #314

Bug 2093288: fix(grpc): Add startupProbe to check for grpc health readiness (#2791) #314

Uh oh!

Conversation

dinhxuanvu commented Jun 3, 2022

Uh oh!

openshift-ci bot commented Jun 3, 2022

Uh oh!

dinhxuanvu commented Jun 3, 2022

Uh oh!

openshift-ci bot commented Jun 3, 2022

Uh oh!

openshift-ci bot commented Jun 3, 2022

Uh oh!

openshift-ci bot commented Jun 3, 2022

Uh oh!

dinhxuanvu commented Jun 3, 2022

Uh oh!

openshift-ci-robot commented Jun 3, 2022

Uh oh!

openshift-ci-robot commented Jun 3, 2022

Uh oh!

openshift-ci-robot commented Jun 4, 2022

Uh oh!

grokspawn commented Jun 4, 2022

Uh oh!

jianzhangbjz commented Jun 6, 2022

Uh oh!

openshift-ci bot commented Jun 6, 2022

Uh oh!

jianzhangbjz commented Jun 6, 2022

Uh oh!

Xia-Zhao-rh commented Jun 6, 2022

Uh oh!

Xia-Zhao-rh commented Jun 6, 2022

Uh oh!

kevinrizza commented Jun 6, 2022

Uh oh!

jianzhangbjz commented Jun 15, 2022

Uh oh!

dinhxuanvu commented Jun 15, 2022

Uh oh!

dinhxuanvu commented Jun 17, 2022

Uh oh!

perdasilva commented Jun 21, 2022

Uh oh!

perdasilva commented Jun 21, 2022

Uh oh!

openshift-ci-robot commented Jun 21, 2022

Uh oh!

perdasilva commented Jun 21, 2022

Uh oh!

openshift-ci bot commented Jun 21, 2022

Uh oh!

openshift-ci bot commented Jun 21, 2022

Uh oh!

dinhxuanvu commented Aug 1, 2022

Uh oh!

openshift-cherrypick-robot commented Aug 1, 2022

Uh oh!

Uh oh!