Skip to content

Bug 2094303: fix(vendor/scoped): bump k8s version to 1.24, go version to 1.18 and fix scoped client (#2794) #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 20, 2022
Merged

Bug 2094303: fix(vendor/scoped): bump k8s version to 1.24, go version to 1.18 and fix scoped client (#2794) #316

merged 7 commits into from
Jun 20, 2022

Conversation

dinhxuanvu
Copy link
Member

  • fix(vendor): bump k8s version to 1.24 and go version to 1.18

Signed-off-by: Vu Dinh [email protected]

  • Update clock package from apimachinery to utils

The apimachinery/pkg/util/clock is deprecated and all clock utils is
on k8s.io/utils/clock repo instead.

Signed-off-by: Vu Dinh [email protected]

  • fix(go.mod): pin opentelemetry packages into specific versions

Signed-off-by: Vu Dinh [email protected]
Co-authored-by: timflannagan [email protected]

  • fix(scoped): update scoped client library to handle token secret

In k8s 1.24, token secret is no longer referenced in ServiceAccount.
By listing all secrets in the namespace and then filter them with
SA name via kubernetes.io/service-account.name annotation, the
token secret can be retrieved successfully.

Signed-off-by: Vu Dinh [email protected]

  • fix(e2e): Fix several RBAC-related e2e test cases

Create token secret for ServiceAccount to ensure those SA
is valid for scoped client use.

Signed-off-by: Vu Dinh [email protected]

Upstream-repository: operator-lifecycle-manager
Upstream-commit: fd9017345aa0fbd7aaed7f0937ff23fca33a9df0

Co-authored-by: timflannagan [email protected]

@dinhxuanvu dinhxuanvu changed the title fix(vendor/scoped): bump k8s version to 1.24, go version to 1.18 and fix scoped client (#2794) Bug 2094303: fix(vendor/scoped): bump k8s version to 1.24, go version to 1.18 and fix scoped client (#2794) Jun 17, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2022

@dinhxuanvu: This pull request references Bugzilla bug 2094303, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

Bug 2094303: fix(vendor/scoped): bump k8s version to 1.24, go version to 1.18 and fix scoped client (#2794)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
@dinhxuanvu dinhxuanvu mentioned this pull request Jun 17, 2022
Merged
@perdasilva
Copy link
Contributor

/label approved

@timflannagan
Copy link
Contributor

It looks like we might need to bump the Go version in the root module.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dinhxuanvu,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@dinhxuanvu dinhxuanvu force-pushed the k8s-1.24 branch 4 times, most recently from 38a623e to ea67d8f Compare June 18, 2022 00:00
@Xia-Zhao-rh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 20, 2022
perdasilva and others added 7 commits June 20, 2022 21:00
@perdasilva
Move ci to go1.18
e60d1c0 
Signed-off-by: perdasilva <[email protected]>
@nsapse @perdasilva
Don't generate kubeclient at runtime in testing (#2790)
54d4acd 
- Updates tests to use common Kube and Runtime clients generated at
startup time rather than having them re-generated in each test at
runtime.
- Closes #2570

Signed-off-by: Noah Sapse <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: c610a3eb2f221a2cac8563b68aa4f98e61f888cc
@perdasilva @timflannagan
fix(vendor/scoped): bump k8s version to 1.24, go version to 1.18 and …
1102deb 
…fix scoped client (#2794)

* fix(vendor): bump k8s version to 1.24 and go version to 1.18

Signed-off-by: Vu Dinh <[email protected]>

* Update clock package from apimachinery to utils

The apimachinery/pkg/util/clock is deprecated and all clock utils is
on k8s.io/utils/clock repo instead.

Signed-off-by: Vu Dinh <[email protected]>

* fix(go.mod): pin opentelemetry packages into specific versions

Signed-off-by: Vu Dinh <[email protected]>
Co-authored-by: timflannagan <[email protected]>

* fix(scoped): update scoped client library to handle token secret

In k8s 1.24, token secret is no longer referenced in ServiceAccount.
By listing all secrets in the namespace and then filter them with
SA name via kubernetes.io/service-account.name annotation, the
token secret can be retrieved successfully.

Signed-off-by: Vu Dinh <[email protected]>

* fix(e2e): Fix several RBAC-related e2e test cases

Create token secret for ServiceAccount to ensure those SA
is valid for scoped client use.

Signed-off-by: Vu Dinh <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: fd9017345aa0fbd7aaed7f0937ff23fca33a9df0

Co-authored-by: timflannagan <[email protected]>
@everettraven @perdasilva
chore: bump k8s deps to 1.24 & makefile go 1.18 support (openshift#242)
fb22a1c 
* bump k8s deps to 1.24 and go version to 1.18

Signed-off-by: Bryce Palmer <[email protected]>

* revert Go 1.18 bump

Signed-off-by: Bryce Palmer <[email protected]>

* revert go 1.18 in workflows

Signed-off-by: Bryce Palmer <[email protected]>

Upstream-repository: api
Upstream-commit: 725ffcedf4774ea71acd9d4a5abfc0f93d1968ed
@everettraven @perdasilva
(chore): bump k8s to 1.24 (openshift#964)
5faa32e 
* changes to bump to k8s 1.24

Signed-off-by: Bryce Palmer <[email protected]>

* changes to bump to k8s 1.24

Signed-off-by: Bryce Palmer <[email protected]>

* update prometheus CRDs to have preserveUnknownFields: false

Signed-off-by: Bryce Palmer <[email protected]>

Upstream-repository: operator-registry
Upstream-commit: 043db4f20c13db8535f6991dd9afd590e7427228
@grokspawn @perdasilva
(chore): bump go to 1.18 (openshift#971)
ad3ea10 
Signed-off-by: Jordan Keister <[email protected]>

Upstream-repository: operator-registry
Upstream-commit: 0899512627ff2fbf6f65e213f0358429959d8963
@perdasilva
Refactor removed_api_tests to tests against sorted strings to avoid f…
277973d 
…lakiness (openshift#245)

* Revert "fix removed_apis_test"

This reverts commit beb9613e0dc43e74ddcc583dfca3e59dd19c2660.

* refactor removed_apis_test to test on sorted error strings to remove flakiness

Signed-off-by: perdasilva <[email protected]>
Upstream-repository: api
Upstream-commit: cb9dc0ee2c6a5c31e04ce1ab0c2eee72d9125ffb
Signed-off-by: perdasilva <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2022

@dinhxuanvu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@perdasilva
Copy link
Contributor

/lgtm

@perdasilva
Copy link
Contributor

/label lgtm

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2022

@perdasilva: The label(s) /label lgtm cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, cherry-pick-approved

In response to this:

/label lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2022
@openshift-ci openshift-ci bot merged commit a8dabfa into openshift:master Jun 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2022

@dinhxuanvu: All pull requests linked via external trackers have merged:

Bugzilla bug 2094303 has been moved to the MODIFIED state.

In response to this:

Bug 2094303: fix(vendor/scoped): bump k8s version to 1.24, go version to 1.18 and fix scoped client (#2794)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Feb 27, 2024
@grokspawn
add missing comments for status fields (openshift#316)
301e9c8 
Upstream-repository: api
Upstream-commit: bdb0455258b952da961e4d2d97b6214a974e0554
@openshift-bot openshift-bot mentioned this pull request Feb 27, 2024
Merged
@perdasilva perdasilva mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timflannagan timflannagan timflannagan approved these changes

@Xia-Zhao-rh Xia-Zhao-rh Awaiting requested review from Xia-Zhao-rh

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@perdasilva perdasilva

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dinhxuanvu @perdasilva @timflannagan @Xia-Zhao-rh @nsapse @everettraven @grokspawn